Skip to content

Make a minor correction to improved VPClass::mustBeNotEqual() - #7428

Merged
vijaysun-omr merged 1 commit into
eclipse-omr:masterfrom
jdmpapin:mustBeNotEqual2
Jul 31, 2024
Merged

vijaysun-omr merged 1 commit into
eclipse-omr:masterfrom
jdmpapin:mustBeNotEqual2

Conversation

@jdmpapin

Copy link
Copy Markdown
Contributor

In 5aba990 the improved VPClass::mustBeNotEqual() mistakenly returned false instead of true for arrays with different lengths. This commit corrects that case to return true as intended. This was not a functional problem because false is a conservative result.

In 5aba990 the improved VPClass::mustBeNotEqual() mistakenly
returned false instead of true for arrays with different lengths. This
commit corrects that case to return true as intended. This was not a
functional problem because false is a conservative result.
@jdmpapin

Copy link
Copy Markdown
Contributor Author

Thanks to @hzongaro for catching this

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Jenkins build all

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Apart from windows infra issue, this has passed testing and is a safe change.

@vijaysun-omr
vijaysun-omr merged commit 192bfd4 into eclipse-omr:master Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants