Repository navigation
Make a minor correction to improved VPClass::mustBeNotEqual() - #7428
Merged
Merged
Conversation
In 5aba990 the improved VPClass::mustBeNotEqual() mistakenly returned false instead of true for arrays with different lengths. This commit corrects that case to return true as intended. This was not a functional problem because false is a conservative result.
Contributor
Author
|
Thanks to @hzongaro for catching this |
vijaysun-omr
approved these changes
Jul 30, 2024
Contributor
|
Jenkins build all |
vijaysun-omr
approved these changes
Jul 31, 2024
Contributor
|
Apart from windows infra issue, this has passed testing and is a safe change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 5aba990 the improved
VPClass::mustBeNotEqual()mistakenly returned false instead of true for arrays with different lengths. This commit corrects that case to return true as intended. This was not a functional problem because false is a conservative result.