Skip to content

Revert "Stop recognizing UTF16_Encoder.encodeUTF16 methods" (2) - #7578

Merged
hzongaro merged 1 commit into
eclipse-omr:masterfrom
knn-k:revertEncodeUTF16_2
Dec 10, 2024
Merged

hzongaro merged 1 commit into
eclipse-omr:masterfrom
knn-k:revertEncodeUTF16_2

Conversation

@knn-k

@knn-k knn-k commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

This commit restores the changes for encodeUTF16Big and encodeUTF16Little that were removed by #7548.

@knn-k

knn-k commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

This commit depends on #7577 and eclipse-openj9/openj9#20722.

This commit restores the changes for encodeUTF16Big and encodeUTF16Little
that were removed by eclipse-omr#7548.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
knn-k force-pushed the revertEncodeUTF16_2 branch from 8b68282 to f70af00 Compare December 3, 2024 22:46
@knn-k

knn-k commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@knn-k

knn-k commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

I changed the enum symbols sun_nio_cs_UTF_16_Encoder_encodeUTF16Big and sun_nio_cs_UTF_16_Encoder_encodeUTF16Little to sun_nio_cs_UTF16_Encoder_encodeUTF16Big and sun_nio_cs_UTF16_Encoder_encodeUTF16Little by removing the _ between UTF and 16 in eclipse-openj9/openj9#20722.

@hzongaro hzongaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro

hzongaro commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

@knn-k, I think this change looks good. I will wait for you to mark it as "Ready for review" before merging.

@knn-k
knn-k marked this pull request as ready for review December 6, 2024 21:35
@hzongaro
hzongaro merged commit 32b0019 into eclipse-omr:master Dec 10, 2024
@knn-k
knn-k deleted the revertEncodeUTF16_2 branch December 10, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants