Repository navigation
Prevent reordering node above its check node - #7607
vijaysun-omr merged 1 commit into
Conversation
cb09e9c to
5c3ed5d
Compare
| stopHere = true; | ||
| } | ||
| // Moving a node earlier than a check may have unforeseeable consequences as sophisticated optimizations like global vp can perform transformations based on value numbers. | ||
| if (!stopHere && currentNode->getOpCode().isCheck()) |
There was a problem hiding this comment.
@hzongaro @vijaysun-omr it was blocking move above checkCast before. I changed it to block moving for all check nodes. Please let me know if it looks good to you. Thanks.
|
All sanity.functional tests passed on arm 64 linux, z linux, and x86-64 linux with java 11 and 21. |
| storeTree->setNextTreeTop(nextTree); | ||
| nextTree->setPrevTreeTop(storeTree); | ||
| } | ||
| } |
There was a problem hiding this comment.
Indentation is not right (before the change, but also after it).
There was a problem hiding this comment.
This closing bracket does not belong to if (stopHere). there is a nested if inside it which this bracket belongs to.
|
Small typo in commit message : "casing" should be "causing" |
|
Small typo in commit message : "abode" should be "above" |
Local reordering was moving nodes above null checks and causing failure. It is also possible that some optimizations do transformations based on value number in check nodes and create bug if child node is relocated above check node. To be safe, I prevent reordering before any check node in this PR. Fixes: eclipse-openj9/openj9#20267 Signed-off-by: Ehsan Kiani Far <ehsan.kianifar@gmail.com>
5c3ed5d to
f37fa67
Compare
|
thanks @vijaysun-omr for your review. I changed the commit message. Also added link to the github issue that it fix but not sure if it was okay since the issue is on openj9 repo. Please let me know if it looks good to you. |
|
I approved, but will wait for @hzongaro to review before I launch more testing. |
hzongaro
left a comment
There was a problem hiding this comment.
I think the change looks good. Thanks for tracking down the problem!
|
Jenkins build all |
|
Checks have passed except zos. Reviews are also done. Merging. |
Reordering should not move a node above where its children are checked.
@hzongaro