Skip to content

Delete unused snippet list printing method from TR_Debug - #7625

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
jdmpapin:unused-snippet-print
Jan 30, 2025
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
jdmpapin:unused-snippet-print

Conversation

@jdmpapin

Copy link
Copy Markdown
Contributor

Snippets are printed instead using the TR::list version of this method, which is defined just prior to it.

Snippets are printed instead using the TR::list version of this method,
which is defined just prior to it.
@jdmpapin

Copy link
Copy Markdown
Contributor Author

@0xdaryl, could you please review?

@0xdaryl 0xdaryl self-assigned this Jan 29, 2025
@0xdaryl

0xdaryl commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Jenkins build all

@jdmpapin

Copy link
Copy Markdown
Contributor Author

In the Windows failure, the build compiler exited with an error status, but I don't see any actual error message from it, just this:

35>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(423,5): error MSB6006: "CL.exe" exited with code 4. [C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\jitbuilder.vcxproj]
35>Done Building Project "C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\jitbuilder.vcxproj" (default targets) -- FAILED.
32>Done Building Project "C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\release\conditionals.vcxproj" (default targets) -- FAILED.
 1>Done Building Project "C:\omr\workspace\PullRequest-win_x86-64\Build\build\ALL_BUILD.vcxproj" (default targets) -- FAILED.

Build FAILED.

There are a bunch of warnings following that, but no errors that I noticed

This answer on Stack Overflow suggests that 4 might indicate an I/O error due to "too many open files"

Then the job timed out. Maybe the machine was just too busy? I'll try it again

@jdmpapin

Copy link
Copy Markdown
Contributor Author

Jenkins build win

@0xdaryl
0xdaryl merged commit 9e6b32c into eclipse-omr:master Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants