Repository navigation
Inhibit preexistence based on the number of preexistence invalidations - #7635
Merged
Merged
Conversation
...rather than all invalidations regardless of the reason. It makes sense to avoid making preexistence assumptions if we've seen that those made in earlier compilations of the same method were invalidated, but invalidations unrelated to preexistence give us no reason to suspect that preexistence assumptions will not hold.
Contributor
Author
|
@dsouzai, could you please review? |
dsouzai
approved these changes
Feb 3, 2025
Contributor
|
jenkins build xlinux |
Contributor
|
^ Nominal testing; the modified code is guarded by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...rather than all invalidations regardless of the reason.
It makes sense to avoid making preexistence assumptions if we've seen that those made in earlier compilations of the same method were invalidated, but invalidations unrelated to preexistence give us no reason to suspect that preexistence assumptions will not hold.