Repository navigation
Lower optimization level workaround for omrzfs.c - #7639
Conversation
|
Using |
|
@joransiu What are your thoughts on this PR? |
|
I have attempted to but unable to address it. Admittedly, I guess I can wrap the lowering of the optimization level restricted only to when using the Open XL compiler with |
|
To mitigate the performance impact, we can try to add |
ec3074f to
776b80b
Compare
|
I tried to disable just the inlining optimization for the functions, but it didn't seem to be working initially. After having a chat with Tony, I confirmed that I had to disable inlining for both the functions, in order to effectively disable the I just verified this today with my latest build that the new changes seem to work, and with these intact we can keep |
|
Minor formatting issue in the commit message: |
776b80b to
ec652ac
Compare
Some functions containing the native call BPX4PCT are causing a crash with Open XL, when they are called back to back in omrzfs. Instead of lowering optimization level to O0 entirely, specifying no inlining for these functions seems to mitigate this problem. This will be used as a workaround until a permanent fix is released. Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@ibm.com>
ec652ac to
0a26902
Compare
|
Thanks for the feedback, yes that is the correct flag. Tested the recommended changes (replaced both instances to conditional to open-xl) and also updated the commit description as suggested. |
|
jenkins build all |
Some functions containing the native call BPX4PCT are causing
a crash with Open XL, when they are called back to back in omrzfs. Instead
of lowering optimization level to O0 entirely, specifying
no inlining for these functions seems to mitigate this problem.
This will be used as a workaround until a permanent fix is
released.
Related: #7653