Skip to content

Don't use known object constraints for remote compilations - #7651

Merged
vijaysun-omr merged 1 commit into
eclipse-omr:masterfrom
mpirvu:disableConstrainstJITServer
Feb 11, 2025
Merged

vijaysun-omr merged 1 commit into
eclipse-omr:masterfrom
mpirvu:disableConstrainstJITServer

Conversation

@mpirvu

@mpirvu mpirvu commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

Adding constraints to "known objects" during remote compilations (at JITServer) results in many messages exchanged between client and server.
This commit rejects the addition of constraints during remote compilations, unless the -Xjit:enableVectorAPIExpansion is present on the command line (these constraints are needed for the VectorAPIExpansion optimization in OpenJ9 project).

Adding constraints to "known objects" during remote compilations
(at JITServer) results in many messages exchanged between client
and server.
This commit rejects the addition of constraints during remote
compilations, unless the -Xjit:enableVectorAPIExpansion is
present on the command line (these constraints are needed for
the VectorAPIExpansion optimization in OpenJ9 project).

Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
@mpirvu
mpirvu requested a review from vijaysun-omr as a code owner February 11, 2025 01:05
@mpirvu

mpirvu commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

Attn: @vijaysun-omr

@vijaysun-omr vijaysun-omr self-assigned this Feb 11, 2025
@vijaysun-omr

Copy link
Copy Markdown
Contributor

Jenkins build all

@vijaysun-omr

Copy link
Copy Markdown
Contributor

I know that @gita-omr is away today, but I am mentioning her so that she knows of this change

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Jenkins build osx

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Jenkins build amac

@mpirvu

mpirvu commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

osx_aarch64 failed a porttest

10:58:37  15: 	**Could not find 0x4000 bytes available with page size 0x4000
10:58:37  15: ***Did not find enough memory available on system, not running test omrvmem_testReserveMemoryExStrictAddress
10:58:37  15: 	NUMA not available
10:58:37  15: [----------] 19 tests from PortVmemTest (388 ms total)
10:58:37  15: 
10:58:37  15: [----------] 41 tests from PortSysinfoTest
10:58:37  15: /Users/omr/workspace/Build/fvtest/porttest/si.cpp line  695: omrsysinfo_test_sysinfo_set_limit_ADDRESS_SPACE omrsysinfo_set_limit set ADDRESS_SPACE soft max FAILED
10:58:37  15: 
10:58:37  15: 		LastErrorNumber: -113
10:58:37  15: 		LastErrorMessage: Invalid argument
10:58:37  15: 
10:58:37  15: /Users/omr/workspace/Build/fvtest/porttest/testHelpers.cpp:109: Failure

I see the same failure in another PR (#7650) so this PR cannot be the source of that error.

@babsingh

babsingh commented Feb 11, 2025 •

Copy link
Copy Markdown
Contributor

The OSX failure was reported in issue #6924, and @knn-k had fixed it (see this comment for the PRs used to resolve the issue). @AdamBrousseau, were there any changes to the OSX machines recently?

@AdamBrousseau

Copy link
Copy Markdown
Contributor

We recently added some mac15 (x & a).
Infra issue 10325 and 10324.
mac15-x86-2 seemed to be working.
mac15-x86-1 and mac15-aarch64-1 were disabled but they must have been re-enabled after a reboot.
I need a dev to look at the failures on these 2 and help us determine if there is a missing machine config or a code issue.

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Merging since tests have passed, apart from known infra issues.

static bool addKnownObjectConstraints(
OMR::ValuePropagation *vp, TR::Node *node, bool isGlobal)
{
// 'addKnownObjectConstraints` has a large overhead for remote compilations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a valid short term solution, I assume there will be investigation done on an ongoing basis to re-enable this logic under JIT server ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look at it, though any code that looks inside objects cannot be processed at the server and needs a message to the client. I am unsure about the value of caching, since the known object table is only valid for the current compilation.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I mention is that the known object table in general can be useful in other contexts, e.g. method handle performance or other cases of code passing in a known object (a string or class constant) to APIs that can be optimized.

@vijaysun-omr
vijaysun-omr merged commit 0b8497b into eclipse-omr:master Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants