Repository navigation
Don't use known object constraints for remote compilations - #7651
Conversation
Adding constraints to "known objects" during remote compilations (at JITServer) results in many messages exchanged between client and server. This commit rejects the addition of constraints during remote compilations, unless the -Xjit:enableVectorAPIExpansion is present on the command line (these constraints are needed for the VectorAPIExpansion optimization in OpenJ9 project). Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
Attn: @vijaysun-omr |
|
Jenkins build all |
|
I know that @gita-omr is away today, but I am mentioning her so that she knows of this change |
|
Jenkins build osx |
|
Jenkins build amac |
|
osx_aarch64 failed a porttest I see the same failure in another PR (#7650) so this PR cannot be the source of that error. |
|
The OSX failure was reported in issue #6924, and @knn-k had fixed it (see this comment for the PRs used to resolve the issue). @AdamBrousseau, were there any changes to the OSX machines recently? |
|
We recently added some mac15 (x & a). |
|
Merging since tests have passed, apart from known infra issues. |
| static bool addKnownObjectConstraints( | ||
| OMR::ValuePropagation *vp, TR::Node *node, bool isGlobal) | ||
| { | ||
| // 'addKnownObjectConstraints` has a large overhead for remote compilations |
There was a problem hiding this comment.
While this is a valid short term solution, I assume there will be investigation done on an ongoing basis to re-enable this logic under JIT server ?
There was a problem hiding this comment.
I will look at it, though any code that looks inside objects cannot be processed at the server and needs a message to the client. I am unsure about the value of caching, since the known object table is only valid for the current compilation.
There was a problem hiding this comment.
The reason I mention is that the known object table in general can be useful in other contexts, e.g. method handle performance or other cases of code passing in a known object (a string or class constant) to APIs that can be optimized.
Adding constraints to "known objects" during remote compilations (at JITServer) results in many messages exchanged between client and server.
This commit rejects the addition of constraints during remote compilations, unless the -Xjit:enableVectorAPIExpansion is present on the command line (these constraints are needed for the VectorAPIExpansion optimization in OpenJ9 project).