Repository navigation
x86: fix EVEX binary encoding of shortened mem-ref - #7652
Merged
Merged
Conversation
BradleyWood
force-pushed
the
evex_mem_iflag_2
branch
from
February 12, 2025 23:13
cf33e18 to
e62705f
Compare
BradleyWood
marked this pull request as ready for review
February 12, 2025 23:17
Contributor
Author
|
@0xdaryl Please review |
Contributor
Author
|
jenkins build all |
BradleyWood
force-pushed
the
evex_mem_iflag_2
branch
from
February 14, 2025 22:15
e62705f to
0b7e9bb
Compare
Contributor
Author
|
jenkins build all |
Contributor
Author
|
msvc is not expanding macros correctly :( |
Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
BradleyWood
force-pushed
the
evex_mem_iflag_2
branch
from
February 17, 2025 13:46
0b7e9bb to
0b18d03
Compare
Contributor
Author
|
jenkins build all |
Contributor
Author
|
@0xdaryl Build looks good now. |
0xdaryl
reviewed
Feb 20, 2025
0xdaryl
reviewed
Feb 20, 2025
BradleyWood
force-pushed
the
evex_mem_iflag_2
branch
from
February 20, 2025 20:37
0b18d03 to
f5b5e12
Compare
Contributor
Author
|
jenkins build all |
0xdaryl
reviewed
Feb 20, 2025
BradleyWood
force-pushed
the
evex_mem_iflag_2
branch
from
February 20, 2025 21:48
f5b5e12 to
b1a29fe
Compare
Contributor
Author
|
jenkins build all |
0xdaryl
reviewed
Feb 21, 2025
| break; | ||
| } | ||
|
|
||
| if (isVector2VectorRatio2x()) |
Contributor
There was a problem hiding this comment.
I believe these ratio properties are all mutually exclusive on an instruction, so this should be an if/else ladder instead to save some pathlength.
Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
BradleyWood
force-pushed
the
evex_mem_iflag_2
branch
from
February 21, 2025 20:06
b1a29fe to
2125ccc
Compare
Contributor
|
Jenkins build xlinux,xmac,win,x32linux |
0xdaryl
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: eclipse-openj9/openj9#21000