Skip to content

x86: fix EVEX binary encoding of shortened mem-ref - #7652

Merged
0xdaryl merged 2 commits into
eclipse-omr:masterfrom
BradleyWood:evex_mem_iflag_2
Feb 21, 2025
Merged

0xdaryl merged 2 commits into
eclipse-omr:masterfrom
BradleyWood:evex_mem_iflag_2

Conversation

@BradleyWood

@BradleyWood BradleyWood commented Feb 12, 2025 •

Copy link
Copy Markdown
Contributor

@BradleyWood
BradleyWood marked this pull request as ready for review February 12, 2025 23:17
@BradleyWood

Copy link
Copy Markdown
Contributor Author

@0xdaryl Please review

@BradleyWood

Copy link
Copy Markdown
Contributor Author

jenkins build all

@BradleyWood

Copy link
Copy Markdown
Contributor Author

jenkins build all

@BradleyWood

Copy link
Copy Markdown
Contributor Author

msvc is not expanding macros correctly :(

Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
@BradleyWood

Copy link
Copy Markdown
Contributor Author

jenkins build all

@BradleyWood

Copy link
Copy Markdown
Contributor Author

@0xdaryl Build looks good now.

Comment thread compiler/x/codegen/OMRInstOpCode.hpp Resolved
Comment thread compiler/x/codegen/OMRInstOpCode.hpp Resolved
@BradleyWood

Copy link
Copy Markdown
Contributor Author

jenkins build all

Comment thread compiler/x/codegen/OMRInstOpCode.hpp Resolved
@BradleyWood

Copy link
Copy Markdown
Contributor Author

jenkins build all

break;
}

if (isVector2VectorRatio2x())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these ratio properties are all mutually exclusive on an instruction, so this should be an if/else ladder instead to save some pathlength.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
@0xdaryl

0xdaryl commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

Jenkins build xlinux,xmac,win,x32linux

@0xdaryl
0xdaryl merged commit 74118d3 into eclipse-omr:master Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants