Skip to content

Improve the Math.min/max_F/D Intrinsics for Power9 or Later - #7664

Merged
dsouzai merged 1 commit into
eclipse-omr:masterfrom
luke-li-2003:MathMinMaxP9
Feb 20, 2025
Merged

dsouzai merged 1 commit into
eclipse-omr:masterfrom
luke-li-2003:MathMinMaxP9

Conversation

@luke-li-2003

Copy link
Copy Markdown
Contributor

Improve the Math.min/max_F/D Intrinsics with xsmaxjdp and xsminjdp instructions introduced on Power9.

@luke-li-2003

Copy link
Copy Markdown
Contributor Author

The instruction will be deployed once eclipse-openj9/openj9#20999 is merged.

@luke-li-2003

Copy link
Copy Markdown
Contributor Author

fyi @zl-wang @hzongaro

dep->addPostCondition(trgReg, TR::RealRegister::NoReg);
if (trgReg != src1Reg)
dep->addPostCondition(src1Reg, TR::RealRegister::NoReg);
dep->addPostCondition(src2Reg, TR::RealRegister::NoReg);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this way, there is no need for registerDependencyCondition. and, as it is, the condition is not used anyway.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the code relating to dependency condition in the branch.

Improve the Math.min/max_F/D Intrinsics with xsmaxjdp and xsminjdp
instructions introduced on Power9.

Signed-off-by: Luke Li <luke.li@ibm.com>

@zl-wang zl-wang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang

zl-wang commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

@dsouzai please review/approve/merge

@dsouzai

dsouzai commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

jenkins build aix,plinux

@dsouzai dsouzai self-assigned this Feb 20, 2025
@dsouzai
dsouzai merged commit 7c9ae30 into eclipse-omr:master Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants