Repository navigation
Improve the Math.min/max_F/D Intrinsics for Power9 or Later - #7664
Merged
Merged
Conversation
Contributor
Author
|
The instruction will be deployed once eclipse-openj9/openj9#20999 is merged. |
Contributor
Author
zl-wang
suggested changes
Feb 19, 2025
| dep->addPostCondition(trgReg, TR::RealRegister::NoReg); | ||
| if (trgReg != src1Reg) | ||
| dep->addPostCondition(src1Reg, TR::RealRegister::NoReg); | ||
| dep->addPostCondition(src2Reg, TR::RealRegister::NoReg); |
Contributor
There was a problem hiding this comment.
this way, there is no need for registerDependencyCondition. and, as it is, the condition is not used anyway.
Contributor
Author
There was a problem hiding this comment.
I removed the code relating to dependency condition in the branch.
Improve the Math.min/max_F/D Intrinsics with xsmaxjdp and xsminjdp instructions introduced on Power9. Signed-off-by: Luke Li <luke.li@ibm.com>
luke-li-2003
force-pushed
the
MathMinMaxP9
branch
from
February 20, 2025 16:39
55edc3d to
6e17811
Compare
Contributor
|
@dsouzai please review/approve/merge |
Contributor
|
jenkins build aix,plinux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the Math.min/max_F/D Intrinsics with xsmaxjdp and xsminjdp instructions introduced on Power9.