Skip to content

Propagate known object info during GlobalCopyPropagation - #7667

Merged
jdmpapin merged 1 commit into
eclipse-omr:masterfrom
gita-omr:cp_known_node
Feb 20, 2025
Merged

jdmpapin merged 1 commit into
eclipse-omr:masterfrom
gita-omr:cp_known_node

Conversation

@gita-omr

Copy link
Copy Markdown
Contributor
  • if original symbol reference on a use node was a known object but the new one is not, set the known object index on the use node

Comment thread compiler/optimizer/CopyPropagation.cpp Resolved
Comment thread compiler/optimizer/CopyPropagation.cpp Resolved
@gita-omr

Copy link
Copy Markdown
Contributor Author

Moved preservation of the known object info into replaceCopySymbolReferenceByOriginalIn(). This covered many more opportunities in my test.

@jdmpapin jdmpapin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming that my one very minor comment will be addressed

Comment thread compiler/optimizer/CopyPropagation.cpp Resolved
@jdmpapin

Copy link
Copy Markdown
Contributor

@vijaysun-omr, do you have any further concerns? If not, then @gita-omr, please squash (after adding static)

@vijaysun-omr

Copy link
Copy Markdown
Contributor

Thanks for making the changes, I approved now

- if original symbol reference on a use node was a known object
  but the new one is not, set the known object index on the use node
@gita-omr

Copy link
Copy Markdown
Contributor Author

Made the function static and squashed.

@jdmpapin

jdmpapin commented Feb 20, 2025 •

Copy link
Copy Markdown
Contributor

Jenkins test sanity all jdk24

@jdmpapin

Copy link
Copy Markdown
Contributor

Jenkins build all

@jdmpapin
jdmpapin merged commit 6c38768 into eclipse-omr:master Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants