Repository navigation
Propagate known object info during GlobalCopyPropagation - #7667
Merged
Merged
Conversation
gita-omr
commented
Feb 19, 2025
Contributor
- if original symbol reference on a use node was a known object but the new one is not, set the known object index on the use node
jdmpapin
reviewed
Feb 19, 2025
Contributor
Author
|
Moved preservation of the known object info into |
jdmpapin
approved these changes
Feb 20, 2025
jdmpapin
left a comment
Contributor
There was a problem hiding this comment.
Approved assuming that my one very minor comment will be addressed
Contributor
|
@vijaysun-omr, do you have any further concerns? If not, then @gita-omr, please squash (after adding |
vijaysun-omr
approved these changes
Feb 20, 2025
Contributor
|
Thanks for making the changes, I approved now |
- if original symbol reference on a use node was a known object but the new one is not, set the known object index on the use node
gita-omr
force-pushed
the
cp_known_node
branch
from
February 20, 2025 15:14
e79c7bf to
320892b
Compare
Contributor
Author
|
Made the function static and squashed. |
Contributor
|
|
Contributor
|
Jenkins build all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.