Skip to content

Remove all references to deprecated 'sigvec' - #972

Merged
youngar merged 1 commit into
eclipse-omr:masterfrom
DanHeidinga:remove_sigvec_support
Apr 6, 2017
Merged

youngar merged 1 commit into
eclipse-omr:masterfrom
DanHeidinga:remove_sigvec_support

Conversation

@DanHeidinga

Copy link
Copy Markdown
Contributor

Glibc 2.21 removes reference to sigvec and calls out the fact that its
an ancient unused interface. Rather than hacking around to support it
on old compilers, let's just remove it.

There are no known upstream consumers of this function.

Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com

Glibc 2.21 removes reference to sigvec and calls out the fact that its
an ancient unused interface.  Rather than hacking around to support it
on old compilers, let's just remove it.

There are no known upstream consumers of this function.

Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
@charliegracie
charliegracie requested a review from youngar April 5, 2017 18:19
@youngar
youngar merged commit 8f90b9b into eclipse-omr:master Apr 6, 2017
FoxieFlakey added a commit to FoxieFlakey/omr that referenced this pull request Apr 20, 2023
This possibly have been overlooked/forgotten by pull request eclipse-omr#972 which removes it from makefile not CMakeLists.txt

The error was occured when using CMake and LLVM toolchain  to build (nightly LLVM 17 toolchain)
```
[ 36%] Linking CXX shared library libomrsig.so
ld.lld: error: version script assignment of 'global' to symbol 'sigvec' failed: symbol not defined
c++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [omrsigcompat/CMakeFiles/omrsig.dir/build.make:103: omrsigcompat/libomrsig.so] Error 1
make[1]: *** [CMakeFiles/Makefile2:1645: omrsigcompat/CMakeFiles/omrsig.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
```

Reproduction
1. `mkdir build`
2. `cmake ..`
3. `make -j$(nproc)`
FoxieFlakey added a commit to FoxieFlakey/omr that referenced this pull request Apr 22, 2023
… sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain
FoxieFlakey added a commit to FoxieFlakey/omr that referenced this pull request Apr 22, 2023
This was overlooked in eclipse-omr#972 which removed all instances of sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain
FoxieFlakey added a commit to FoxieFlakey/omr that referenced this pull request Mar 18, 2024
… sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain
FoxieFlakey added a commit to FoxieFlakey/omr that referenced this pull request Mar 19, 2024
This was overlooked in eclipse-omr#972 which removed all instances of sigvec.

Fixes the below LLVM toolchain error:

error: version script assignment of 'global' to symbol 'sigvec'
failed: symbol not defined error when using LLVM toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants