Repository navigation
Remove all references to deprecated 'sigvec' - #972
Merged
Merged
Conversation
Glibc 2.21 removes reference to sigvec and calls out the fact that its an ancient unused interface. Rather than hacking around to support it on old compilers, let's just remove it. There are no known upstream consumers of this function. Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
FoxieFlakey
added a commit
to FoxieFlakey/omr
that referenced
this pull request
Apr 20, 2023
This possibly have been overlooked/forgotten by pull request eclipse-omr#972 which removes it from makefile not CMakeLists.txt The error was occured when using CMake and LLVM toolchain to build (nightly LLVM 17 toolchain) ``` [ 36%] Linking CXX shared library libomrsig.so ld.lld: error: version script assignment of 'global' to symbol 'sigvec' failed: symbol not defined c++: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [omrsigcompat/CMakeFiles/omrsig.dir/build.make:103: omrsigcompat/libomrsig.so] Error 1 make[1]: *** [CMakeFiles/Makefile2:1645: omrsigcompat/CMakeFiles/omrsig.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... ``` Reproduction 1. `mkdir build` 2. `cmake ..` 3. `make -j$(nproc)`
FoxieFlakey
added a commit
to FoxieFlakey/omr
that referenced
this pull request
Apr 22, 2023
… sigvec. Fixes the below LLVM toolchain error: error: version script assignment of 'global' to symbol 'sigvec' failed: symbol not defined error when using LLVM toolchain
FoxieFlakey
added a commit
to FoxieFlakey/omr
that referenced
this pull request
Apr 22, 2023
This was overlooked in eclipse-omr#972 which removed all instances of sigvec. Fixes the below LLVM toolchain error: error: version script assignment of 'global' to symbol 'sigvec' failed: symbol not defined error when using LLVM toolchain
FoxieFlakey
added a commit
to FoxieFlakey/omr
that referenced
this pull request
Mar 18, 2024
… sigvec. Fixes the below LLVM toolchain error: error: version script assignment of 'global' to symbol 'sigvec' failed: symbol not defined error when using LLVM toolchain
FoxieFlakey
added a commit
to FoxieFlakey/omr
that referenced
this pull request
Mar 19, 2024
This was overlooked in eclipse-omr#972 which removed all instances of sigvec. Fixes the below LLVM toolchain error: error: version script assignment of 'global' to symbol 'sigvec' failed: symbol not defined error when using LLVM toolchain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glibc 2.21 removes reference to sigvec and calls out the fact that its
an ancient unused interface. Rather than hacking around to support it
on old compilers, let's just remove it.
There are no known upstream consumers of this function.
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com