Skip to content

-Xshareclasses automatically turns on -XX:+ShareOrphans #1354

Closed

Description

@hangshao0

Issue or pull request number:
eclipse-openj9/openj9#19679

Overview:
OpenJ9 introduced options -XX:+ShareOrphans and -XX:-ShareOrphans in 0.46 release. See #1330. User has to explicitly specify -XX:+ShareOrphans to turn on this feature. In 0.47 release, if option -Xshareclasses is specified in the command line, it automatically turns on -XX:+ShareOrphans.

Release target:
Eclipse OpenJ9 0.47

Applies to the following JDK versions:
All versions

Applies to the following platforms:
All platforms

Activity

  1. Sreekala-Gopakumar commented on Aug 30, 2024

    @Sreekala-Gopakumar
    Contributor

    In the documentation, we have mentioned that the " -XX:+ShareOrphans option automatically enables the -Xshareclasses option." So, now with this change, whichever option is enabled first, the other option will be enabled automatically? Is my understanding correct?

  2. Sreekala-Gopakumar commented on Aug 30, 2024

    @Sreekala-Gopakumar
    Contributor

    Also, please refer to #1383 (comment) regarding the following 2 known problems.

    The class comparison might not detect the removal of method access modifiers. For example, a change of a method from public to package-private.
    java.lang.StackTraceElement.getClassLoaderName() might return null for classes that are stored in the shared cache.

    As per your comment in #1330 (comment), are these 2 known problems now fixed in 0.47.0 release?

  3. hangshao0 commented on Aug 30, 2024

    @hangshao0
    ContributorAuthor

    In the documentation, we have mentioned that the " -XX:+ShareOrphans option automatically enables the -Xshareclasses option." So, now with this change, whichever option is enabled first, the other option will be enabled automatically? Is my understanding correct?

    Yes, so in 0.46, users have to specify -XX:+ShareOrphans (either -XX:+ShareOrphans alone or -XX:+ShareOrphans + their existing -Xshareclasses option) to turn on this new feature. In 0.47, users with existing -Xshareclasses options do not need to specify -XX:+ShareOrphans anymore.

  4. hangshao0 commented on Aug 30, 2024

    @hangshao0
    ContributorAuthor

    As per your comment in #1330 (comment), are these 2 known problems now fixed in 0.47.0 release?

    Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions