Repository navigation
(0.29.1) Avoid combining a regular type bound with a ClassObject location in VP - #129
Merged
0xdaryl merged 3 commits intoOct 26, 2021
Conversation
This logic was repeated for both VPResolvedClass and VPFixedClass, and conspicuously missing from VPUnresolvedClass. (cherry picked from commit 6be9456)
Any value known to satisfy the VPClassType constraint is an object, so it must be a reflective object rather than a VM-internal representation. (cherry picked from commit 85d2e95)
...as the intersection of the two constraints. If the type is not already known to be a ClassObject, then bundling it into a VPClass with a ClassObject location will incorrectly change the meaning of the type constraint. (cherry picked from commit d4ba4d4)
0xdaryl
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just eclipse-omr/omr#6208 cherry-picked onto v0.29.1-release. The diff should be identical to the diff in that PR
Fixes eclipse-openj9/openj9#13167