Repository navigation
(0.51) Add missing edge in block splitter - #222
Merged
vijaysun-omr merged 1 commit intoMar 7, 2025
Merged
vijaysun-omr merged 1 commit into
vijaysun-omr merged 1 commit into
Conversation
There is a case where before block splitter, the merge block is the original fall-through block of the split block and it is also the split block's branch destination. In this case, there is only one edge from the split block to the merge block. --- Before block splitter --- BBStart <block_1> (splitPred) ificmpeq ------> block_2 BBStart <block_2> (mergeNode) As part of the block splitter transformation, it removes the edge from the split block to its original branch destination. It reverses the split block's branch destination to its original fall-through block. In this case the new branch destination is the same as the original branch destination, but the edge between them is now missing. We need to create the edge if it doesn't exist. --- After block splitter --- BBStart <block_1> (splitPred) ificmpne -----> block_2 // branch reversed BBStart <block_3> (cloneStart) BBStart <block_4> (cloneEnd) BBStart <block_2> (mergeNode) ----------------------------- Fixes: eclipse-openj9/openj9#21030 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Contributor
Author
vijaysun-omr
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry pick eclipse-omr/omr#7680
There is a case where before block splitter, the merge block is the original fall-through block of the split block and it is also the split block's branch destination. In this case, there is only one edge from the split block to the merge block.
As part of the block splitter transformation, it removes the edge from the split block to its original branch destination. It reverses the split block's branch destination to its original fall-through block. In this case the new branch destination is the same as the original branch destination, but the edge between them is now missing.
We need to create the edge if it doesn't exist.
Fixes: eclipse-openj9/openj9#21030