Repository navigation
(0.51) Avoid storing PassThrough nodes to temps when splitting blocks - #224
Merged
vijaysun-omr merged 1 commit intoMar 13, 2025
Conversation
With fixupCommoning, any node commoned across the split point is stored into a temp, and occurrences after the split are replaced with a load. If this happened with a PassThrough node, we would generate BadILOp because PassThrough claims to have type NoType. In particular, the store would be BadILOp, and it would appear that a conversion is needed at the load, and the conversion would also be BadILOp. While determining which nodes are commoned across the split point, any PassThrough node encountered with refcount greater than 1 will now be replaced with a fresh PassThrough node with refcount 1. This way, no PassThrough node will be found to commoned across the split point. (cherry picked from commit 7879fa4)
vijaysun-omr
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of eclipse-omr/omr#7686 for 0.51.