Repository navigation
(0.51.0) Check for all interfaces implemented by java/lang/Class in VP - #227
Merged
vijaysun-omr merged 1 commit intoMar 19, 2025
Conversation
Code in VPClassType::isJavaLangClassObject() tests whether the VPClassType object refers to an instance of one of the interfaces that are known to be implemented by java/lang/Class. The set of interfaces that were considered was incomplete, as it was missing interfaces that were added in JDK 12: java.lang.constant.Constable java.lang.invoke.TypeDescriptor java.lang.invoke.TypeDescriptor$OfField That resulted in VPClassType::isJavaLangClassObject() returning TR_no for any reference that is known to be an instance of one of those interface classes rather than TR_maybe. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
Member
Author
|
@vijaysun-omr, if you are OK with this change, may I ask you to merge it to the v0.51.0-release branch? |
vijaysun-omr
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code in
VPClassType::isJavaLangClassObject()tests whether theVPClassTypeobject refers to an instance of one of the interfaces that are known to be implemented byjava/lang/Class. The set of interfaces that were considered was incomplete, as it was missing interfaces that were added in JDK 12:That resulted in
VPClassType::isJavaLangClassObject()returningTR_nofor any reference that is known to be an instance of one of those interface classes rather thanTR_maybe.Fixes: eclipse-openj9/openj9#21031
Port of eclipse-omr/omr#7691 to v0.51.0-release branch