Repository navigation
(0.51) In splitPostGRA(), find the GlRegDeps for switch children correctly - #232
Merged
hzongaro merged 1 commit intoMar 28, 2025
Conversation
We've been looking for GlRegDeps as the last child of node, which is the top-level switch node, when we should have instead been looking at the last child of branch, i.e. the last child of the child of node. This caused splitPostGRA() to completely ignore GlRegDeps beneath switch nodes, which could result in failure to generate a register store. Without a register store, the GlRegDeps could end up with a PassThrough whose child doesn't occur in any prior tree. (cherry picked from commit c75bac4)
hzongaro
approved these changes
Mar 28, 2025
Member
|
@pshipton, FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of eclipse-omr/omr#7705 for 0.51