Skip to content

(0.51) In splitPostGRA(), find the GlRegDeps for switch children correctly - #232

Merged
hzongaro merged 1 commit into
eclipse-openj9:v0.51.0-releasefrom
jdmpapin:splitPostGRA-switch-0.51
Mar 28, 2025
Merged

hzongaro merged 1 commit into
eclipse-openj9:v0.51.0-releasefrom
jdmpapin:splitPostGRA-switch-0.51

Conversation

@jdmpapin

Copy link
Copy Markdown
Contributor

Cherry pick of eclipse-omr/omr#7705 for 0.51

We've been looking for GlRegDeps as the last child of node, which is the
top-level switch node, when we should have instead been looking at the
last child of branch, i.e. the last child of the child of node.

This caused splitPostGRA() to completely ignore GlRegDeps beneath switch
nodes, which could result in failure to generate a register store.
Without a register store, the GlRegDeps could end up with a PassThrough
whose child doesn't occur in any prior tree.

(cherry picked from commit c75bac4)
@hzongaro hzongaro self-assigned this Mar 28, 2025
@hzongaro
hzongaro merged commit 9bcff94 into eclipse-openj9:v0.51.0-release Mar 28, 2025
@hzongaro

Copy link
Copy Markdown
Member

@pshipton, FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants