You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-XX:-UseCompressedOops should be equivalent to -Xnocompressedrefs, and I see there is some code in the redirector which looks at it, but it doesn't work. Guessing it's been broken since mixed refs.
java -XX:-UseCompressedOops -version
semeru version "11.0.12" 2021-07-20
Semeru Runtime Environment 11.0.12.0-m2 (build 11.0.12+6)
Eclipse OpenJ9 VM 11.0.12.0-m2 (build v0.27.0-release-5b9d76f56, JRE 11 Linux amd64-64-Bit Compressed References 20210716_218 (JIT enabled, AOT enabled)
The -XX variants are not understood by the VM itself, so perhaps the internal redirector is translating them into the J9-specific ones. Probably adding a MAPOPT for the XX versions in the VM would solve this (and any handling can be removed from the redirector).
@tajila I'm setting this as a blocker, as it means all testing running with -XX:-UseCompressedOops isn't testing what it's supposed to be testing, which could be letting problems escape.
I would start with this approach: Probably adding a MAPOPT for the XX versions in the VM would solve this (and any handling can be removed from the redirector).
Following code snippet setting J9_EXTENDED_RUNTIME2_COMPRESS_OBJECT_REFERENCES need to be skipped when -XX:-UseCompressedOops is specified, i.e., command line or user environment option should overwrite automatic switching to compressedrefs. Edit: The issue was introduced by Mixedrefs work which only considered -Xcompressedrefs & -Xnocompressedrefs, -XX:+UseCompressedOops & -XX:-UseCompressedOops are ignored when setting J9_EXTENDED_RUNTIME2_COMPRESS_OBJECT_REFERENCES.
Activity
pshipton commentedon Sep 23, 2021
Works fine for IBM Java 8. @dmitripivkine fyi in case you know why it's not working.
gacholio commentedon Sep 24, 2021
The -XX variants are not understood by the VM itself, so perhaps the internal redirector is translating them into the J9-specific ones. Probably adding a MAPOPT for the XX versions in the VM would solve this (and any handling can be removed from the redirector).
pshipton commentedon Oct 7, 2021
@tajila I'm setting this as a blocker, as it means all testing running with
-XX:-UseCompressedOopsisn't testing what it's supposed to be testing, which could be letting problems escape.llxia commentedon Oct 7, 2021
Created an issue for adding cmdlinetests for -XX:[+/-]UseCompressedOops #13660
tajila commentedon Oct 8, 2021
@JasonFengJ9 Please take a look at this
tajila commentedon Oct 8, 2021
I would start with this approach:
Probably adding a MAPOPT for the XX versions in the VM would solve this (and any handling can be removed from the redirector).pshipton commentedon Oct 8, 2021
I think it needs to stay, we can't break non-mixed refs builds i.e. IBM Java 8.
JasonFengJ9 commentedon Oct 8, 2021
Following code snippet setting
J9_EXTENDED_RUNTIME2_COMPRESS_OBJECT_REFERENCESneed to be skipped when-XX:-UseCompressedOopsis specified,i.e., command line or user environment option should overwrite automatic switching to.compressedrefsEdit: The issue was introduced by
Mixedrefswork which only considered-Xcompressedrefs&-Xnocompressedrefs,-XX:+UseCompressedOops&-XX:-UseCompressedOopsare ignored when settingJ9_EXTENDED_RUNTIME2_COMPRESS_OBJECT_REFERENCES.openj9/runtime/vm/jvminit.c
Lines 3686 to 3712 in 3201c84
On the other hand,
-Xnocompressedrefsbehaves as expected.gacholio commentedon Oct 9, 2021
I really mean that the redirector need not fiddle with any options in mixed mode - let the targetted VM handle it.
gacholio commentedon Oct 9, 2021
I was hoping the MAPOPT would address this.
pshipton commentedon Oct 13, 2021
Fix merged to 0.29 #13691