Skip to content

AArch64: JDKnext build failure with value type enabled (--enable-inline-types) #13916

Closed

Description

@a7ehuo

I ran into the follow build failure with value type enabled build (--enable-inline-types) on Aarch64 with JDKNext: Pipeline_Build_Test_JDKnext_aarch64_linux_vt_standard. It's 100% reproducible.

vmState [0x40000]: {J9VMSTATE_JNI}

[2021-11-14T17:16:42.576Z] Using OPENJDK_REPO = git@github.com:ibmruntimes/openj9-openjdk-jdk.git OPENJDK_BRANCH = openj9 OPENJDK_SHA = 7a1dc45cca2f02e16ba9584cb1dfc4a8e01ab6af
[Pipeline] echo
[2021-11-14T17:16:42.587Z] Using OPENJ9_REPO = git@github.com:eclipse/openj9.git OPENJ9_BRANCH = master OPENJ9_SHA = d13611eb2648febf73e4fb25ed3e31e900a497a9
[Pipeline] echo
[2021-11-14T17:16:42.588Z] Using OMR_REPO = git@github.com:eclipse/openj9-omr.git OMR_BRANCH = openj9 OMR_SHA = b95fd53e283564bb45eb96be5fd7bd137271073b
...
[2021-11-14T17:18:05.351Z] + bash configure --with-boot-jdk=/home/jenkins/bootjdks/jdk17 --with-openssl=fetched --enable-inline-types
...
[2021-11-14T17:38:52.223Z] Creating java.management.jmod
[2021-11-14T17:38:54.319Z] Unhandled exception
[2021-11-14T17:38:54.319Z] Type=Segmentation error vmState=0x00040000
[2021-11-14T17:38:54.319Z] J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
[2021-11-14T17:38:54.319Z] Handler1=0000400033427A78 Handler2=00004000335F9650 InaccessibleAddress=0000000099669924
[2021-11-14T17:38:54.319Z] R0=000000000AE5A00F R1=00000000FFC38BE8 R2=00000000FFC38BE8 R3=0000000000000001
[2021-11-14T17:38:54.319Z] R4=000000000000000F R5=0000000099669900 R6=000000000007BC00 R7=000040006C0CF0EC
[2021-11-14T17:38:54.319Z] R8=00004000394B2E2C R9=000000000000000F R10=00000000FFC2C5E0 R11=00000000FFC2C5E0
[2021-11-14T17:38:54.319Z] R12=0000000043AC580F R13=0000000000000000 R14=0000000000088400 R15=00000000FFC38280
[2021-11-14T17:38:54.319Z] R16=00004000335C0250 R17=0000400032DF82D8 R18=00004000335C34F8 R19=0000000000019200
[2021-11-14T17:38:54.319Z] R20=00000000001064F0 R21=00000000FFC38BE8 R22=00000000FFC38BE8 R23=0000000000000001
[2021-11-14T17:38:54.319Z] R24=000000000000000F R25=00000000FFC2C5E0 R26=0000000043AC580F R27=0000000000000000
[2021-11-14T17:38:54.319Z] R28=0000000000000001 R29=0000000000000047 R30=00004000394B2E2C R31=000040003312B550
[2021-11-14T17:38:54.319Z] PC=00004000394B3884 SP=000040003312B550 PSTATE=0000000080000000
[2021-11-14T17:38:54.319Z] V0 0000000000000005 (f: 5.000000, d: 2.470328e-323)
[2021-11-14T17:38:54.319Z] V1 000000003e3ab283 (f: 1044034176.000000, d: 5.158214e-315)
[2021-11-14T17:38:54.319Z] V2 000000003a5cc94c (f: 979159360.000000, d: 4.837690e-315)
[2021-11-14T17:38:54.319Z] V3 000000003d7e3982 (f: 1031682432.000000, d: 5.097188e-315)
[2021-11-14T17:38:54.319Z] V4 00000000bc29865d (f: 3156837888.000000, d: 1.559685e-314)
[2021-11-14T17:38:54.319Z] V5 000000003d57f306 (f: 1029174016.000000, d: 5.084795e-315)
[2021-11-14T17:38:54.319Z] V6 0000000041c80000 (f: 1103626240.000000, d: 5.452638e-315)
[2021-11-14T17:38:54.319Z] V7 00000000396d7337 (f: 963474240.000000, d: 4.760195e-315)
[2021-11-14T17:38:54.319Z] V8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V15 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V16 fffffffcfffffffc (f: 4294967296.000000, d: -nan)
[2021-11-14T17:38:54.319Z] V17 0000400038318340 (f: 942768960.000000, d: 3.476724e-310)
[2021-11-14T17:38:54.319Z] V18 0000400038318330 (f: 942768960.000000, d: 3.476724e-310)
[2021-11-14T17:38:54.319Z] V19 0000400038318350 (f: 942768960.000000, d: 3.476724e-310)
[2021-11-14T17:38:54.319Z] V20 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V21 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V22 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V23 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V24 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V25 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V26 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V27 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V28 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V29 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V30 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] V31 0000000000000000 (f: 0.000000, d: 0.000000e+00)
[2021-11-14T17:38:54.319Z] 
[2021-11-14T17:38:54.319Z] Compiled_method=java/util/concurrent/ConcurrentHashMap.putVal(Ljava/lang/Object;Ljava/lang/Object;Z)Ljava/lang/Object;
[2021-11-14T17:38:54.319Z] Target=2_90_20211114_3 (Linux 4.18.0-305.10.2.el7.aarch64)
[2021-11-14T17:38:54.319Z] CPU=aarch64 (8 logical CPUs) (0x1dc310000 RAM)
[2021-11-14T17:38:54.319Z] ----------- Stack Backtrace -----------
[2021-11-14T17:38:54.319Z] (0x00004000335F62A8 [libj9prt29.so+0x262a8])
[2021-11-14T17:38:54.319Z] ---------------------------------------
[2021-11-14T17:38:54.319Z] JVMDUMP039I Processing dump event "gpf", detail "" at 2021/11/14 12:38:53 - please wait.
[2021-11-14T17:38:54.319Z] JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Build_JDKnext_aarch64_linux_vt_standard_Personal/make/core.20211114.123853.11362.0001.dmp' in response to an event
...

Activity

  1. a7ehuo commented on Nov 15, 2021

    @a7ehuo
    ContributorAuthor

    @knn-k @0xdaryl fyi
    The value type enabled build on other platforms seem fine.

  2. knn-k commented on Nov 15, 2021

    @knn-k
    Contributor

    I implemented monitor enter/exit for value types for AArch64 in #10494.
    What else do I need for supporting value types?

  3. knn-k commented on Nov 15, 2021

    @knn-k
    Contributor

    I reproduced the segmentation error in ConcurrentHashMap.putVal() in building with --enable-inline-types locally.
    The method seems to try to access the address 0x99669924 (= R5 + 0x24).

  4. a7ehuo commented on Nov 15, 2021

    @a7ehuo
    ContributorAuthor

    What else do I need for supporting value types?

    Monitor enter/exit check on value type is the only place I'm aware of that needs to be implemented at the platform specific tree evaluators.

  5. Akira1Saitoh commented on Nov 16, 2021

    @Akira1Saitoh

    Hmm.. I think we need to use tst instruction instead of and.

    generateTrg1MemInstruction(cg, TR::InstOpCode::ldrimmw, node, temp1Reg, classFlagsMemRef);
    loadConstant32(cg, node, classFlag, temp2Reg);
    generateTrg1Src2Instruction(cg, TR::InstOpCode::andw, node, temp1Reg, temp1Reg, temp2Reg);
    bool generateOOLSection = helperCallLabel == NULL;
    if (generateOOLSection)
    helperCallLabel = generateLabelSymbol(cg);
    // If obj is value type or value based class instance, call VM helper and throw IllegalMonitorState exception, else continue as usual
    generateConditionalBranchInstruction(cg, TR::InstOpCode::b_cond, node, helperCallLabel, TR::CC_NE);

  6. Akira1Saitoh commented on Nov 16, 2021

    @Akira1Saitoh

    I think we also need to add some guard in VMnewEvaluator.
    #8520

  7. added a commit that references this issue on Nov 16, 2021
    17ecbf8
  8. knn-k commented on Nov 17, 2021

    @knn-k
    Contributor

    Build_JDKnext_aarch64_linux_vt_standard_Personal went successful in #13928.

  9. a7ehuo commented on Nov 17, 2021

    @a7ehuo
    ContributorAuthor

    Awesome! Thanks for the quick fix, @knn-k @Akira1Saitoh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions