Skip to content

Add cmdlinetests for -XX:+UseCompressedOops and -XX:-UseCompressedOops - #13724

Merged
llxia merged 1 commit into
eclipse-openj9:masterfrom
ixlongz:xx1
Oct 21, 2021
Merged

llxia merged 1 commit into
eclipse-openj9:masterfrom
ixlongz:xx1

Conversation

@ixlongz

@ixlongz ixlongz commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Longyu Zhang longyu.zhang@ibm.com

@ixlongz

ixlongz commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

Use $JAVA_COMMAND$ instead of $EXE$ is because $EXE$ sometimes contains “-XX:+UseCompressedOops” option itself, see output for 11:03:32 Testing: Verify rightmost -XX:-UseCompressedOops overrides earlier -Xcompressedrefs -XX:+UseCompressedOops

Test Links (on Adopt Jenkins https://ci.adoptopenjdk.net/job/Grinder/):
jdk11: aarch: 1715 aix: 1716 zlinux: 1717 plinux: 1713 win: 1718 zos: hyc_18791
jdk8: mac: 1764
jdk17: zlinux: 1762

@ixlongz

ixlongz commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

@llxia @JasonFengJ9 Could you review it? Thanks.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change wasn't seen in other command line testers, why is it required?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mode with NoOption, Mode150. and Mode 650 are all tested now. Thanks.

@llxia

llxia commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Could we use $EXE$ in XXArgumentTesting.xml and add <variation>NoOptions</variation> in playlist.xml?

@ixlongz
ixlongz force-pushed the xx1 branch 2 times, most recently from 7662c37 to 68db271 Compare October 19, 2021 02:13

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newline at end of file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thanks.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add -nonZeroExitWhenError; \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add <output type="failure" caseSensitive="no" regex="no">Unhandled Exception</output> here and following tests.

@ixlongz
ixlongz force-pushed the xx1 branch 2 times, most recently from 784dd4c to f145e7a Compare October 19, 2021 16:50

@JasonFengJ9 JasonFengJ9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @LongyuZhang

@llxia

llxia commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

@LongyuZhang could you please provide a Grinder link for hotpsot run?

@ixlongz
ixlongz force-pushed the xx1 branch 3 times, most recently from fbe5554 to 3b6c618 Compare October 19, 2021 20:24
@ixlongz

ixlongz commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

@llxia New subtests have been moved to j9 version test as discussed.
Test Links:
openj9:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • it should be -Xnocompressedrefs not --Xnocompressedrefs
  • it should be -XX:+UseCompressedOops or -Xcompressedrefs not -Xcompressedrefs or -Xcompressedrefs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thanks.

@llxia llxia Oct 20, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to test up to 3 combinations, test links:

  • jdk 8: plinux: 18861
  • jdk 11: plinux: 18859 zos:18862
  • jdk 17: plinux: 18860

- Add cmdlinetests for -XX:[+/-]UseCompressedOops
[skip ci]

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@llxia

llxia commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

jenkins test sanity plinux,win jdk8,jdk11

@llxia llxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LongyuZhang

@llxia
llxia merged commit 50eeb85 into eclipse-openj9:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants