Repository navigation
Print compilation thread shutdown message - #13784
Conversation
d6f4a7d to
cd049eb
Compare
cd049eb to
5281173
Compare
ymanton
left a comment
There was a problem hiding this comment.
This won't print anything to the vlog by default, it's gated by TR_VerbosePerformance, which is not part of the verbose sub-options that are in effect by default.
It needs to print something to the vlog when one does java -Xjit:verbose -version, so you need to figure out what, if anything, to gate it by. For reference, the default verbose sub-options is defined here in the entry for "verbose":
TR::OptionTable OMR::Options::_feOptions[] =
{
{"code=", "C<nnn>\tsize of a single code cache, in KB",
TR::Options::set32BitNumericInJitConfig, offsetof(OMR::FrontEnd::JitConfig, options.codeCacheKB), 0, " %d (KB)"},
{"exclude=", "D{regexp}\tdo not compile methods matching regexp", TR::Options::limitOption, 1, 0, "P%s"},
{"limit=", "D{regexp}\tonly compile methods matching regexp", TR::Options::limitOption, 0, 0, "P%s"},
{"limitfile=", "D<filename>\tfilter methods as defined in filename. "
"Use limitfile=(filename,firstLine,lastLine) to limit lines considered from firstLine to lastLine", TR::Options::limitfileOption, 0, 0, "P%s"},
{"verbose", "L\twrite compiled method names to vlog file or stdout in limitfile format",
TR::Options::setVerboseBits, offsetof(TR::JitConfig, options.verboseFlags), (1<<TR_VerboseCompileStart)|(1<<TR_VerboseCompileEnd), "F=1"},
{"verbose=", "L{regex}\tlist of verbose output to write to vlog or stdout",
TR::Options::setVerboseBits, offsetof(TR::JitConfig, options.verboseFlags), 0, "F"},
{"version", "M\tprint out JIT version", TR::Options::versionOption, 0, 0, "F"},
{"vlog=", "L<filename>\twrite verbose output to filename",
TR::Options::setStringInJitConfig, offsetof(TR::JitConfig, options.vLogFileName), 0, "P%s"},
{0}
};
Your options are to introduce a new verbose sub-option and add it to the default set, use one of the existing ones (e.g. TR_VerboseCompileEnd), or find some other means to get the desired effect.
5281173 to
feb9ab4
Compare
|
I think I am able to print the verbose log message by default by moving the print statement outside of the conditional that checks to see if the TR_VerbosePerformance verbose option is supplied. |
ymanton
left a comment
There was a problem hiding this comment.
This will take a lock and do a lot of pointless work even if verbose output is not requested. We can do better; try using the TR::Options::isAnyVerboseOptionSet() query to gate your message.
Also, please describe what you're doing, provide an example of the output, and ask for any feedback in #421.
feb9ab4 to
29b50d2
Compare
|
I think the verbose log message should now be displayed when any verbose option is supplied 29b50d2. |
ymanton
left a comment
There was a problem hiding this comment.
Let's find a different tag for this message; it isn't related to performance so TR_Vlog_PERF doesn't make sense.
Closes: eclipse-openj9#421 Signed-off-by: Amarpreet Singh amarpreet1997@gmail.com
29b50d2 to
08a2a7a
Compare
|
I think the verbose log message now begins with the string that is described by the TR_Vlog_INFO enum.
|
|
Jenkins test sanity.functional all jdk11 |
mpirvu
left a comment
There was a problem hiding this comment.
LGTM, though some may argue that simply saying -Xjit:verbose should produce only the lines for compilation ends which are needed for a limitfile.
|
I think the pull request could be merged. |
|
@ymanton could you please approve this PR if you are satisfied with the current version? |
ymanton
left a comment
There was a problem hiding this comment.
LGTM.
All of the tests have passed despite Test_openjdk11_j9_sanity.functional_x86-64_mac_Personal showing as still running.
|
Merging based on the above comment |
Closes: #421
Signed-off-by: Amarpreet Singh amarpreet1997@gmail.com