Skip to content

Add assertions to JCL startup failures - #13864

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:booterrmsg
Nov 8, 2021
Merged

pshipton merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:booterrmsg

Conversation

@JasonFengJ9

@JasonFengJ9 JasonFengJ9 commented Nov 4, 2021 •

Copy link
Copy Markdown
Member

These assertions indicate the startup failure location to avoid a silent VM exit.

Related to #13852 (comment)

Signed-off-by: Jason Feng fengj@ca.ibm.com

@keithc-ca
keithc-ca requested a review from pshipton November 4, 2021 17:44
@keithc-ca

Copy link
Copy Markdown
Contributor

This seems reasonable, but I'd like a second opinion from @pshipton.

Comment thread runtime/jcl/common/jclcinit.c Resolved
Comment thread runtime/jcl/common/jclcinit.c Resolved
Comment thread runtime/jcl/j9jcl.tdf Resolved
@JasonFengJ9
JasonFengJ9 force-pushed the booterrmsg branch 2 times, most recently from ee30419 to a595016 Compare November 5, 2021 03:37
@JasonFengJ9 JasonFengJ9 changed the title Add Assertions to initializeKnownClasses failures Add assertions to JCL startup failures Nov 5, 2021
Comment thread runtime/jcl/j9jcl.tdf Resolved
These assertions indicate the startup failure location to avoid a
silent VM exit.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@pshipton

pshipton commented Nov 6, 2021

Copy link
Copy Markdown
Member

jenkins test compile zlinux jdk8

@pshipton
pshipton merged commit 4fc70b1 into eclipse-openj9:master Nov 8, 2021
@a7ehuo

a7ehuo commented Nov 11, 2021 •

Copy link
Copy Markdown
Contributor

I'm running into the following JCL assert in jclcinit.c:328 in my personal Jenkins build for JDKNext x86-64_linux_vt_standard build. @JasonFengJ9 Is this a known issue for JDKNext?

[2021-11-11T01:48:44.088Z] Using OPENJDK_REPO = git@github.com:ibmruntimes/openj9-openjdk-jdk.git OPENJDK_BRANCH = openj9 OPENJDK_SHA = 6b0732d47e2d7f855e2b420b6ed05e4c7c989313
[Pipeline] echo
[2021-11-11T01:48:44.099Z] Using OPENJ9_REPO = git@github.com:a7ehuo/openj9.git OPENJ9_BRANCH = master OPENJ9_SHA = c35516b686b4a16f1569787c2dbca67b01ea1b59
[Pipeline] echo
[2021-11-11T01:48:44.100Z] Using OMR_REPO = git@github.com:a7ehuo/omr.git OMR_BRANCH = master OMR_SHA = e86f1f627acd0af2c5f0786fadcd0a9c62cdad67
...
...
[2021-11-11T02:14:10.093Z] Optimizing the exploded image
[2021-11-11T02:14:10.093Z] 02:14:05.473 0x16f00   j9jcl.520    *   ** ASSERTION FAILED ** at /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/openj9/runtime/jcl/common/jclcinit.c:328: ((0 ))
[2021-11-11T02:14:10.093Z] JVMDUMP039I Processing dump event "traceassert", detail "" at 2021/11/10 18:14:05 - please wait.
[2021-11-11T02:14:10.093Z] JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/make/core.20211110.181405.23961.0001.dmp' in response to an event
[2021-11-11T02:14:10.093Z] JVMDUMP010I System dump written to /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/make/core.20211110.181405.23961.0001.dmp
[2021-11-11T02:14:10.093Z] JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/make/javacore.20211110.181405.23961.0002.txt' in response to an event
[2021-11-11T02:14:10.093Z] JVMDUMP010I Java dump written to /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/make/javacore.20211110.181405.23961.0002.txt
[2021-11-11T02:14:10.093Z] JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/make/Snap.20211110.181405.23961.0003.trc' in response to an event
[2021-11-11T02:14:10.093Z] JVMDUMP010I Snap dump written to /home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/make/Snap.20211110.181405.23961.0003.trc
[2021-11-11T02:14:10.093Z] JVMDUMP013I Processed dump event "traceassert", detail "".
[2021-11-11T02:14:10.093Z] gmake[3]: *** [/home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/build/linux-x86_64-server-release/jdk/_optimize_image_exec.marker] Error 1
[2021-11-11T02:14:10.093Z] ExplodedImageOptimize.gmk:39: recipe for target '/home/jenkins/workspace/Build_JDKnext_x86-64_linux_vt_standard_Personal/build/linux-x86_64-server-release/jdk/_optimize_image_exec.marker' failed
[2021-11-11T02:14:10.093Z] gmake[2]: *** [exploded-image-optimize] Error 1
[2021-11-11T02:14:10.093Z] make/Main.gmk:441: recipe for target 'exploded-image-optimize' failed

@JasonFengJ9

Copy link
Copy Markdown
Member Author

@a7ehuo your personal branch master needs a rebase to get latest commits matching extension repo updates.

@JasonFengJ9
JasonFengJ9 deleted the booterrmsg branch April 4, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants