Skip to content

AArch64: Implement a helper for Patchable GCRs - #13867

Merged
knn-k merged 1 commit into
eclipse-openj9:masterfrom
Akira1Saitoh:aarch64GCRPatching
Nov 8, 2021
Merged

knn-k merged 1 commit into
eclipse-openj9:masterfrom
Akira1Saitoh:aarch64GCRPatching

Conversation

@Akira1Saitoh

Copy link
Copy Markdown

This commit implements a helper for Patchable GCRs on aarch64.

Depends on eclipse-omr/omr#6227

Signed-off-by: Akira Saitoh saiaki@jp.ibm.com

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a tab character between .globl and FUNC_LABEL.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to a tab.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a tab character between the opcode and the operands.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed those lines to use a tab character.

@Akira1Saitoh
Akira1Saitoh force-pushed the aarch64GCRPatching branch 2 times, most recently from 76e5543 to 81cc483 Compare November 5, 2021 04:47
@Akira1Saitoh
Akira1Saitoh marked this pull request as ready for review November 8, 2021 01:42
@knn-k

knn-k commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

jenkins test sanity alinux64 jdk11

@knn-k

knn-k commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

jenkins test sanity alinux64 jdk11 depends eclipse-omr/omr#6228

This commit implements a helper for Patchable GCRs on aarch64.

Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
@knn-k

knn-k commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

jenkins test sanity alinux64 jdk11 depends eclipse-omr/omr#6228

@knn-k knn-k self-assigned this Nov 8, 2021
@knn-k
knn-k merged commit 6786a4f into eclipse-openj9:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants