Skip to content

Tidy up CRIU support - #13934

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:criu
Nov 17, 2021
Merged

tajila merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:criu

Conversation

@keithc-ca

Copy link
Copy Markdown
Contributor
  • inline CRIU checkpoint state (only if needed)
  • add missing #endif comments

Comment thread runtime/vm/criuhelpers.cpp Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this entire function under a single #ifdef? There is no reason for this function here to be called if the CRIU flag is not enabled.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do that (I was just maintaining the set of functions defined).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is now only compiled if CRIU support is configured.

@tajila
tajila requested a review from dsouzai November 16, 2021 20:28
@tajila

tajila commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Adding Irwin to review the JIT changes

@dsouzai dsouzai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No functional changes added to JIT, so LGTM for the JIT files.

@keithc-ca
keithc-ca marked this pull request as draft November 16, 2021 21:52
* inline CRIU checkpoint state (only if needed)
* add missing #endif comments
* compile criuhelpers.cpp only if CRIU support is configured
* only declare functions when they will be defined

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@keithc-ca
keithc-ca marked this pull request as ready for review November 17, 2021 03:03
@tajila tajila added criu Used to track CRIU snapshot related work comp:vm comp:jit labels Nov 17, 2021
@tajila

tajila commented Nov 17, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk8

@tajila
tajila merged commit 5bd7e26 into eclipse-openj9:master Nov 17, 2021
@keithc-ca
keithc-ca deleted the criu branch November 17, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:jit comp:vm criu Used to track CRIU snapshot related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants