Repository navigation
Tidy up CRIU support - #13934
Merged
Merged
Tidy up CRIU support#13934
Conversation
tajila
reviewed
Nov 16, 2021
Contributor
There was a problem hiding this comment.
Can we put this entire function under a single #ifdef? There is no reason for this function here to be called if the CRIU flag is not enabled.
Contributor
Author
There was a problem hiding this comment.
Sure, I can do that (I was just maintaining the set of functions defined).
Contributor
Author
There was a problem hiding this comment.
The file is now only compiled if CRIU support is configured.
Contributor
|
Adding Irwin to review the JIT changes |
dsouzai
reviewed
Nov 16, 2021
dsouzai
left a comment
Contributor
There was a problem hiding this comment.
No functional changes added to JIT, so LGTM for the JIT files.
keithc-ca
marked this pull request as draft
November 16, 2021 21:52
* inline CRIU checkpoint state (only if needed) * add missing #endif comments * compile criuhelpers.cpp only if CRIU support is configured * only declare functions when they will be defined Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
keithc-ca
marked this pull request as ready for review
November 17, 2021 03:03
tajila
approved these changes
Nov 17, 2021
Contributor
|
Jenkins test sanity win jdk8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#endifcomments