Skip to content

Move ASGCT resolve frame to proper scope - #13979

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
gacholio:frame
Nov 25, 2021
Merged

tajila merged 1 commit into
eclipse-openj9:masterfrom
gacholio:frame

Conversation

@gacholio

Copy link
Copy Markdown
Contributor

The variable was being declared in an inner scope and the address of
said variable used in an outer scope.

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

The variable was being declared in an inner scope and the address of
said variable used in an outer scope.

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
@gacholio

Copy link
Copy Markdown
Contributor Author

No test covers the modified code.

@tajila

tajila commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Jenkins compile win jdk8

@gacholio

Copy link
Copy Markdown
Contributor Author

Seems jenkins isn't listening to this PR.

@eclipse-openj9 eclipse-openj9 deleted a comment from tajila Nov 24, 2021
@tajila

tajila commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Jenkins compile win jdk8

@tajila

tajila commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk8

1 similar comment
@tajila

tajila commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk8

@tajila

tajila commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

@tajila

tajila commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Turns out it passed yesterday, https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/1243/

I guess there was just an issue updating the github UI

@tajila
tajila merged commit 5cbb929 into eclipse-openj9:master Nov 25, 2021
@gacholio
gacholio deleted the frame branch November 25, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants