Repository navigation
Disable stackMap cache during ASGCT - #14007
Merged
Merged
Conversation
Do not use the cache as it may be in an inconsistent state. Also, do not allocate a new cache to avoid malloc during signal handler. Remove unnecessary stack map query in dump creation. Related: eclipse-openj9#13838 Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
keithc-ca
reviewed
Nov 25, 2021
Contributor
|
Jenkins test sanity win jdk11 |
Contributor
Author
|
For whatever reason, pipeline updates are not being posted properly to PRs. |
Contributor
|
Yes, but the pipeline passed: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/1252. |
keithc-ca
approved these changes
Nov 25, 2021
Member
|
This has broken some 32-bit compilation. i.e. https://openj9-jenkins.osuosl.org/job/Build_JDK8_x86-32_windows_Nightly/162/console I'll revert for now until it can be fixed. |
Contributor
Author
|
Unrevert and fix in #14023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use the cache as it may be in an inconsistent state. Also, do not
allocate a new cache to avoid malloc during signal handler.
Remove unnecessary stack map query in dump creation.
Related: #13838
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com