Skip to content

Disable stackMap cache during ASGCT - #14007

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
gacholio:metadata
Nov 25, 2021
Merged

keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
gacholio:metadata

Conversation

@gacholio

Copy link
Copy Markdown
Contributor

Do not use the cache as it may be in an inconsistent state. Also, do not
allocate a new cache to avoid malloc during signal handler.

Remove unnecessary stack map query in dump creation.

Related: #13838

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

Do not use the cache as it may be in an inconsistent state. Also, do not
allocate a new cache to avoid malloc during signal handler.

Remove unnecessary stack map query in dump creation.

Related: eclipse-openj9#13838

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>

@mpirvu mpirvu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread runtime/codert_vm/jswalk.c Resolved
@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk11

@gacholio

Copy link
Copy Markdown
Contributor Author

For whatever reason, pipeline updates are not being posted properly to PRs.

@keithc-ca

Copy link
Copy Markdown
Contributor

Yes, but the pipeline passed: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/1252.

@keithc-ca
keithc-ca merged commit 161b225 into eclipse-openj9:master Nov 25, 2021
@gacholio
gacholio deleted the metadata branch November 25, 2021 21:45
@pshipton

Copy link
Copy Markdown
Member

This has broken some 32-bit compilation. i.e. https://openj9-jenkins.osuosl.org/job/Build_JDK8_x86-32_windows_Nightly/162/console

21:35:54  SignalHandler.c
21:35:54  F:\Users\jenkins\workspace\Build_JDK8_x86-32_windows_Nightly\openj9\runtime\compiler\runtime\SignalHandler.c(401) : error C2220: warning treated as error - no 'object' file generated
21:35:54  F:\Users\jenkins\workspace\Build_JDK8_x86-32_windows_Nightly\openj9\runtime\compiler\runtime\SignalHandler.c(401) : warning C4133: 'function' : incompatible types - from 'J9JavaVM *' to 'J9VMThread *'

I'll revert for now until it can be fixed.

@gacholio

Copy link
Copy Markdown
Contributor Author

Unrevert and fix in #14023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants