Skip to content

(0.30.0) Fix the start of internal control flow and deps - #14294

Merged
pshipton merged 1 commit into
eclipse-openj9:v0.30.0-releasefrom
a7ehuo:fix-StringLatin1-inflate-v0.30.0-release
Jan 18, 2022
Merged

pshipton merged 1 commit into
eclipse-openj9:v0.30.0-releasefrom
a7ehuo:fix-StringLatin1-inflate-v0.30.0-release

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Jan 17, 2022 •

Copy link
Copy Markdown
Contributor

In inlining StringLatin1Inflate, srcBufferReg and destBufferReg
should be added on the register dependency list. The internal
control flow should start right after the register dependency setup,
so that if any register is spilled to stack before the internal
control flow, they can be restored properly at the end.

Fixes: #13983

Port of #14287 for the 0.30 release.

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

In inlining StringLatin1Inflate, srcBufferReg and destBufferReg
should be added on the register dependency list. The internal
control flow should start right after the register dependency setup,
so that if any register is spilled to stack before the internal
control flow, they can be restored properly at the end.

Fixes: eclipse-openj9#13983

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo requested a review from 0xdaryl January 17, 2022 22:18
@a7ehuo a7ehuo changed the title Fix the start of internal control flow and deps (0.30.0) Fix the start of internal control flow and deps Jan 17, 2022
@0xdaryl

0xdaryl commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

@pshipton : we just merged #14287 into master today so it hasn't had any time to soak, but it is a generally safe fix. I have approved this PR for the 0.30 release. We can merge it now or wait until at least one round of master testing has completed.

@pshipton

Copy link
Copy Markdown
Member

Let's merge it in the morning once the nightly builds have been checked.

@pshipton

Copy link
Copy Markdown
Member

No concerns in the overnight builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants