Skip to content

Remove MaxDirectMemorySize default size in JDK11+ - #14623

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
tajila:userRaised
Mar 3, 2022
Merged

pshipton merged 1 commit into
eclipse-openj9:masterfrom
tajila:userRaised

Conversation

@tajila

@tajila tajila commented Mar 2, 2022 •

Copy link
Copy Markdown
Contributor

Remove MaxDirectMemorySize default size in JDK11+

When sun.nio.MaxDirectMemorySize (AKA -XX:MaxDirectMemorySize) is not
set the JDK defaults to Xmx in JDK11 builds.

Fixes #14503

Doc issue eclipse-openj9/openj9-docs#905

Signed-off-by: Tobi Ajila atobia@ca.ibm.com

When sun.nio.MaxDirectMemorySize (AKA -XX:MaxDirectMemorySize) is not
set the JDK defaults to Xmx in JDK11 builds.

Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
@tajila

tajila commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins test sanity win jdk8

@tajila

tajila commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Jenkins test sanity plinux jdk11,jdk17,jdk18

@pshipton

pshipton commented Mar 2, 2022

Copy link
Copy Markdown
Member

We'll have to update the doc for this change to the defaults.
https://www.eclipse.org/openj9/docs/xxmaxdirectmemorysize/

@pshipton

pshipton commented Mar 3, 2022

Copy link
Copy Markdown
Member

fwiw the test passed in a grinder on plinux https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/688/

@pshipton

pshipton commented Mar 3, 2022

Copy link
Copy Markdown
Member

Created doc issue eclipse-openj9/openj9-docs#905

@pshipton

pshipton commented Mar 3, 2022

Copy link
Copy Markdown
Member

@tajila Pls cherry pick for the 0.32 branch.

pshipton added a commit to pshipton/openj9 that referenced this pull request Mar 3, 2022
PR eclipse-openj9#14623

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9 that referenced this pull request Mar 28, 2022
Setting -1 sets the default direct memory size to the same as -Xmx.

See also eclipse-openj9#14623

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9 that referenced this pull request Mar 29, 2022
Setting -1 sets the default direct memory size to the same as -Xmx.

See also eclipse-openj9#14623

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton added a commit to pshipton/openj9 that referenced this pull request Mar 29, 2022
Setting -1 sets the default direct memory size to the same as -Xmx.

See also eclipse-openj9#14623

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants