Repository navigation
Remove MaxDirectMemorySize default size in JDK11+ - #14623
Merged
Merged
Conversation
When sun.nio.MaxDirectMemorySize (AKA -XX:MaxDirectMemorySize) is not set the JDK defaults to Xmx in JDK11 builds. Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Contributor
Author
|
Jenkins test sanity win jdk8 |
Contributor
Author
|
Jenkins test sanity plinux jdk11,jdk17,jdk18 |
Member
|
We'll have to update the doc for this change to the defaults. |
pshipton
approved these changes
Mar 3, 2022
Member
|
fwiw the test passed in a grinder on plinux https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/688/ |
Member
|
Created doc issue eclipse-openj9/openj9-docs#905 |
Member
|
@tajila Pls cherry pick for the 0.32 branch. |
This was referenced Mar 3, 2022
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Mar 3, 2022
PR eclipse-openj9#14623 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Mar 28, 2022
Setting -1 sets the default direct memory size to the same as -Xmx. See also eclipse-openj9#14623 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Mar 29, 2022
Setting -1 sets the default direct memory size to the same as -Xmx. See also eclipse-openj9#14623 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9
that referenced
this pull request
Mar 29, 2022
Setting -1 sets the default direct memory size to the same as -Xmx. See also eclipse-openj9#14623 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MaxDirectMemorySize default size in JDK11+
When sun.nio.MaxDirectMemorySize (AKA -XX:MaxDirectMemorySize) is not
set the JDK defaults to Xmx in JDK11 builds.
Fixes #14503
Doc issue eclipse-openj9/openj9-docs#905
Signed-off-by: Tobi Ajila atobia@ca.ibm.com