Skip to content

AArch64: Suppress compiler warnings in ExternalRelocation - #14876

Merged
0xdaryl merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64_cast_warnings
Apr 12, 2022
Merged

0xdaryl merged 1 commit into
eclipse-openj9:masterfrom
knn-k:aarch64_cast_warnings

Conversation

@knn-k

@knn-k knn-k commented Apr 7, 2022

Copy link
Copy Markdown
Contributor

This commit changes some calls to ExternalRelocation constructor to
suppress the following compiler warning:
warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

This commit changes some calls to ExternalRelocation constructor to
suppress the following compiler warning:
`warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]`

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k

knn-k commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

See a related PR eclipse-omr/omr#6461 and a related issue: #14859.

@knn-k

knn-k commented Apr 7, 2022

Copy link
Copy Markdown
Contributor Author

jenkins test sanity alinux64 jdk17

@knn-k
knn-k requested a review from 0xdaryl April 8, 2022 00:40
@knn-k

knn-k commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

There are two lines of warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] remaining in https://openj9-jenkins.osuosl.org/job/Build_JDK17_aarch64_linux_Personal/135/consoleText, which are fixed by eclipse-omr/omr#6461 when promoted.

@pshipton

pshipton commented Apr 8, 2022 •

Copy link
Copy Markdown
Member

eclipse-omr/omr#6461 was promoted, so I think this can be closed now? I though this was the issue. Obviously, this needs to be merged.

@knn-k

knn-k commented Apr 8, 2022 •

Copy link
Copy Markdown
Contributor Author

This PR fixes AArch64-specific warnings that were not addressed in Issue #14859.

From https://openj9-jenkins.osuosl.org/job/Build_JDK17_aarch64_linux_gcc10_Nightly/4/consoleText:

[2022-04-08T01:13:16.831Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/CallSnippet.cpp: In member function 'virtual uint8_t* TR::ARM64CallSnippet::emitSnippetBody()':
[2022-04-08T01:13:16.831Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/CallSnippet.cpp:290:97: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
[2022-04-08T01:13:16.831Z]   290 |                                                                                     getNode() ? (uint8_t *)getNode()->getInlinedSiteIndex() : (uint8_t *)-1,
[2022-04-08T01:13:16.831Z]       |                                                                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[2022-04-08T01:13:16.831Z] [ 91%] Built target j9gcvrbevents_full
[2022-04-08T01:13:16.831Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/CallSnippet.cpp: In member function 'virtual uint8_t* TR::ARM64UnresolvedCallSnippet::emitSnippetBody()':
[2022-04-08T01:13:16.831Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/CallSnippet.cpp:490:44: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
[2022-04-08T01:13:16.831Z]   490 |                                getNode() ? (uint8_t *)getNode()->getInlinedSiteIndex() : (uint8_t *)-1,
[2022-04-08T01:13:16.831Z]       |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[2022-04-08T01:13:16.831Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/CallSnippet.cpp: In member function 'virtual uint8_t* TR::ARM64VirtualUnresolvedSnippet::emitSnippetBody()':
[2022-04-08T01:13:16.831Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/CallSnippet.cpp:608:44: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
[2022-04-08T01:13:16.831Z]   608 |                                getNode() ? (uint8_t *)getNode()->getInlinedSiteIndex() : (uint8_t *)-1,
[2022-04-08T01:13:16.831Z]       |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[2022-04-08T01:13:20.639Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/J9UnresolvedDataSnippet.cpp: In member function 'virtual uint8_t* J9::ARM64::UnresolvedDataSnippet::emitSnippetBody()':
[2022-04-08T01:13:20.639Z] /home/jenkins/workspace/Build_JDK17_aarch64_linux_gcc10_Nightly/openj9/runtime/compiler/aarch64/codegen/J9UnresolvedDataSnippet.cpp:126:28: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
[2022-04-08T01:13:20.639Z]   126 |                getNode() ? (uint8_t *)getNode()->getInlinedSiteIndex() : (uint8_t *)-1,
[2022-04-08T01:13:20.639Z]       |                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@0xdaryl 0xdaryl self-assigned this Apr 12, 2022
@0xdaryl

0xdaryl commented Apr 12, 2022

Copy link
Copy Markdown
Contributor

Jenkins compile amac jdk17

@0xdaryl
0xdaryl merged commit cd9f623 into eclipse-openj9:master Apr 12, 2022
@knn-k
knn-k deleted the aarch64_cast_warnings branch April 12, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants