Repository navigation
Add missing java preprocessor flag for wi32 platform - #14884
Conversation
|
I often let it slide, but the commit comment could use more context, i.e. it should contain "jpp" or "java preprocessor" so anyone reading the title would have an idea where the platform was missing. |
Since just a single file is modified, I thought it was clear, but I'll expand it. |
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
There is no problem when looking at the change, but if you are looking through a list of changes, such as https://github.com/eclipse-openj9/openj9/releases/tag/openj9-0.30.0, it's nice to have as much context as possible in the "title". |
|
You're right, I hadn't thought of that context. Updated. |
No description provided.