Skip to content

Add missing java preprocessor flag for wi32 platform - #14884

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:jpp_platform
Apr 7, 2022
Merged

pshipton merged 1 commit into
eclipse-openj9:masterfrom
keithc-ca:jpp_platform

Conversation

@keithc-ca

Copy link
Copy Markdown
Contributor

No description provided.

@keithc-ca
keithc-ca requested a review from pshipton April 7, 2022 16:37
@pshipton

pshipton commented Apr 7, 2022

Copy link
Copy Markdown
Member

I often let it slide, but the commit comment could use more context, i.e. it should contain "jpp" or "java preprocessor" so anyone reading the title would have an idea where the platform was missing.

@keithc-ca

Copy link
Copy Markdown
Contributor Author

I often let it slide, but the commit comment could use more context, i.e. it should contain "jpp" or "java preprocessor" so anyone reading the title would have an idea where the platform was missing.

Since just a single file is modified, I thought it was clear, but I'll expand it.

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@pshipton

pshipton commented Apr 7, 2022

Copy link
Copy Markdown
Member

There is no problem when looking at the change, but if you are looking through a list of changes, such as https://github.com/eclipse-openj9/openj9/releases/tag/openj9-0.30.0, it's nice to have as much context as possible in the "title".

@keithc-ca

Copy link
Copy Markdown
Contributor Author

You're right, I hadn't thought of that context. Updated.

@pshipton pshipton changed the title Add missing platform flag for wi32 Add missing java preprocessor flag for wi32 platform Apr 7, 2022
@pshipton
pshipton merged commit 43ba34d into eclipse-openj9:master Apr 7, 2022
@keithc-ca
keithc-ca deleted the jpp_platform branch April 7, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants