Repository navigation
Add missing Q type checks - #16411
Conversation
95d591c to
f180a75
Compare
|
There are DDR and minor GC changes, adding @keithc-ca @dmitripivkine as reviewers. |
dmitripivkine
left a comment
There was a problem hiding this comment.
GC related code (couple of files) looks ok to me. There is one remark left for commented out lines - I would prefer to not have them in final commit but not strong on this (what purpose these lines suppose to serve?)
3478e09 to
9987875
Compare
There was a problem hiding this comment.
While you're here, please fix the preprocessor lines 654 & 658: # should be at the beginning of the line and #if should be omitted from the #endif comment.
There was a problem hiding this comment.
I've noticed there are a lot more places in the codebase that have these inconsistencies in both C and Java preprocessor comments (most of which are my fault). I could fix all of them in a separate PR if you think it's worthwhile? Alternatively I could fix them in this PR (would only be about 40 more lines changed but it would touch files that haven't been changed yet in this PR).
There was a problem hiding this comment.
I think it's reasonable to fix those other files in this pull request.
There was a problem hiding this comment.
I fixed all the existing inconsistent C preprocessor comments in 6d7788e, but not all the Java ones because there turned out to be way more than I thought (around 150 instances). Is that still reasonable for this PR do you think?
There was a problem hiding this comment.
I'm happy to defer a cleanup of those Java source files.
|
Please also correct the typo in the commit message: "location" should be "locations" and sentences should end with a period. |
7678ed1 to
6d7788e
Compare
c1370a2 to
89dde4a
Compare
|
Jenkins test sanity,extended xlinuxval jdknext |
|
Jenkins test sanity plinuxvalst jdknext |
|
Jenkins test sanity win jdk8 |
There was a problem hiding this comment.
I found the source of the build failure (I used sigOffset here by accident instead of index), and when I tested this code earlier I didn't test it on JDK8. But I'm not sure why this was only an error on JDK8 builds?
There was a problem hiding this comment.
The same error appears on line 465 as well.
There was a problem hiding this comment.
The same error appears on line 465 as well.
- Add a Q type check in all locations in which a Q type should be handled the same way as an L type - Change comments after #else and #endif directives to be consistent For issue eclipse-openj9#15861 Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
89dde4a to
e51ed56
Compare
|
@hzongaro Do you know why this PR would affect the inlineMap? |
|
@ehrenjulzert can you see how reproduceable that test failure is? |
|
In case the error in question is not related to this PR, @ehrenjulzert please create an issue so we can track it separately. |
|
Ok, I'm rerunning it in test grinder now. |
|
I re-ran the test on grinder but it failed again (https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/30501/). I also tried to find an available nightly |
|
There are no regular |
No youll need a VT build |
|
@ehrenjulzert you can make a VT build without your changes with the |
It looks like the last PR build doesn't exist anymore, I assume because we don't run |
Sure I can run that, although to be clear: is |
Yeah, last PR build has been purged, just launched one w/ default branches - https://openj9-jenkins.osuosl.org/job/Build_JDKnext_s390x_linux_vt_standard_Personal/11 |
I guess you could also rerun the EDIT: nvm I see Jason has launched it |
Thanks Jason! Sorry about all the confusion. |
|
I ran the tests and they passed this time (https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/30541/), which surprises me since my decomp.cpp changes look equivalent to what was there previously. Looking more into it now |
|
Can you get a core file when the error occurs? You can look at https://www.ibm.com/docs/en/sdk-java-technology/8?topic=options-xtrace#trigger to see how you can trigger a core on that tracepoint (tracepoint IDs can be found in jdk/lib/J9TraceFormat.dat |
Ehren @ehrenjulzert, FYI - I was able to reproduce the failure in a Grinder run of a build without this change, https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/30530/ - assuming I didn't mess up my own build somehow. |
This seems correct to me, looks like the test only sometimes fails. That would be a bit of a coincidence since I ran the test twice with my changes and the error was reproduced each time, and I also ran the test twice without my changes and it passed both times. I'm running multiple iterations of the same test on my branch here to see if it sometimes passes: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/30642/ |
|
@ehrenjulzert Have you concluded that the failure predates your changes? |
|
Not yet, I'm unsure how to interpret the different results that Henry and I got. Assuming we both ran our Jenkins tests correctly the results indicate that the test sometimes fails on master but always fails on my branch. I was thinking that it may have to do with the machine that my tests were running on, but didn’t get a chance to look into it last week. I was planning on running more tests some time today. |
|
Jenkins test sanity zlinuxvalst jdknext |
|
@ehrenjulzert can you see if that test passes without the changes in decomp.c |
Sure, I'll try that now |
|
Yes, there's still intermittent failures without the decomp.cpp changes (https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/30845/) |
|
Oops I didn't notice until now that |
Add a Q type check in all locations in which a
Q type should be handled the same way as an L type
For issue #15861
Signed-off-by: Ehren Julien-Neitzert ehren.julien-neitzert@ibm.com