Skip to content

Remove wantToPatchClassPointer() and the hcrPatchClassPointers option - #16481

Merged
0xdaryl merged 1 commit into
eclipse-openj9:masterfrom
jdmpapin:wantToPatchClassPointer
Feb 4, 2023
Merged

0xdaryl merged 1 commit into
eclipse-openj9:masterfrom
jdmpapin:wantToPatchClassPointer

Conversation

@jdmpapin

Copy link
Copy Markdown
Contributor

These were introduced a long time ago to allow a certain change to be toggled. The change was to stop generating runtime assumptions for patching class pointers on class redefinition, and to stop generating slower but more easily patchable instruction sequences to allow for those runtime assumptions. The patching was no longer needed because class redefinition had been made in-place.

As a result, wantToPatchClassPointer() and hcrPatchClassPointers are no longer necessary. They are removed, and all use sites now behave as though hcrPatchClassPointers is not set and wantToPatchClassPointer() returns false.

These were introduced a long time ago to allow a certain change to be
toggled. The change was to stop generating runtime assumptions for
patching class pointers on class redefinition, and to stop generating
slower but more easily patchable instruction sequences to allow for
those runtime assumptions. The patching was no longer needed because
class redefinition had been made in-place.

As a result, wantToPatchClassPointer() and hcrPatchClassPointers are no
longer necessary. They are removed, and all use sites now behave as
though hcrPatchClassPointers is not set and wantToPatchClassPointer()
returns false.
@jdmpapin

Copy link
Copy Markdown
Contributor Author

This and eclipse-omr/omr#6851 will require a coordinated merge.

@0xdaryl

0xdaryl commented Feb 3, 2023

Copy link
Copy Markdown
Contributor

Jenkins test sanity all jdk8,jdk11,jdk17 depends eclipse-omr/omr#6851

@0xdaryl

0xdaryl commented Feb 4, 2023

Copy link
Copy Markdown
Contributor

Both failing CI jobs are variants of #13577.

@0xdaryl 0xdaryl self-assigned this Feb 4, 2023
@0xdaryl
0xdaryl merged commit 5b5e82d into eclipse-openj9:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants