Repository navigation
Include the product name in the DTFJ JavaRuntime version - #16941
Merged
Merged
Conversation
pshipton
force-pushed
the
dsysprops
branch
2 times, most recently
from
March 17, 2023 02:11
0043db9 to
bc283d3
Compare
keithc-ca
requested changes
Mar 17, 2023
Member
Author
|
Addressed the review comments. |
keithc-ca
requested changes
Mar 17, 2023
Contributor
|
Jenkins compile alinux64 jdk17 |
Contributor
|
This isn't quite done. Running |
Contributor
|
The line in |
The jdmpview `info system` output includes the JavaRuntime version. Also include the product name in the !coreinfo output. Only OpenJ9 builds have a product name. Issue eclipse-openj9#16930 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Member
Author
|
Updated it and it's working now. |
keithc-ca
approved these changes
Mar 18, 2023
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
Build succeeded (https://openj9-jenkins.osuosl.org/view/Pull%20Requests/job/PullRequest-OpenJ9/3525/) and I verified locally that the latest change addresses the problem accessing older core files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jdmpview
info systemoutput includes the JavaRuntime version. Also include the product name in the !coreinfo output.Only OpenJ9 builds have a product name.
Closes #16930