Skip to content

Include the product name in the DTFJ JavaRuntime version - #16941

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:dsysprops
Mar 18, 2023
Merged

keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:dsysprops

Conversation

@pshipton

@pshipton pshipton commented Mar 16, 2023 •

Copy link
Copy Markdown
Member

The jdmpview info system output includes the JavaRuntime version. Also include the product name in the !coreinfo output.

Only OpenJ9 builds have a product name.

Closes #16930

@pshipton
pshipton requested a review from keithc-ca March 16, 2023 22:30
@pshipton
pshipton force-pushed the dsysprops branch 2 times, most recently from 0043db9 to bc283d3 Compare March 17, 2023 02:11
Comment thread runtime/oti/j9nonbuilder.h Resolved
@pshipton

Copy link
Copy Markdown
Member Author

Addressed the review comments.

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins compile alinux64 jdk17

@keithc-ca

Copy link
Copy Markdown
Contributor

This isn't quite done. Running !coreinfo on a core generated by "Eclipse OpenJ9 VM 11.0.17.0 (build openj9-0.35.0)" yields

	*0 : PID: 441798 : Exception in thread "main" java.lang.NoSuchMethodError: com/ibm/j9ddr/vm29/pointer/generated/J9RASPointer.productName()Lcom/ibm/j9ddr/vm29/pointer/U8Pointer; (loaded from <Unknown> by J9DDRClassloader for com.ibm.j9ddr.vm29.) called from class com.ibm.j9ddr.vm29.view.dtfj.java.DTFJJavaRuntime (loaded from <Unknown> by J9DDRClassloader for com.ibm.j9ddr.vm29.).
	at com.ibm.j9ddr.vm29.view.dtfj.java.DTFJJavaRuntime.getVersion(DTFJJavaRuntime.java:939)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.CombinedContext.getJREVersion(CombinedContext.java:313)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.CombinedContext.displayContext(CombinedContext.java:291)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.Session.showContexts(Session.java:306)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.Session.runBatch(Session.java:687)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.Session.run(Session.java:667)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.DTFJView.launch(DTFJView.java:52)
	at openj9.dtfjview/com.ibm.jvm.dtfjview.DTFJView.main(DTFJView.java:46)

@keithc-ca

Copy link
Copy Markdown
Contributor

The line in AuxFieldInfo29.dat needs to be

J9RAS.productName = U8*

The jdmpview `info system` output includes the JavaRuntime version.
Also include the product name in the !coreinfo output.

Only OpenJ9 builds have a product name.

Issue eclipse-openj9#16930

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton

Copy link
Copy Markdown
Member Author

Updated it and it's working now.

@keithc-ca keithc-ca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build succeeded (https://openj9-jenkins.osuosl.org/view/Pull%20Requests/job/PullRequest-OpenJ9/3525/) and I verified locally that the latest change addresses the problem accessing older core files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Semeru Open/Certified Edition in coredump

2 participants