Skip to content

FIPS disable JCL_TEST_Java-Security tests - #19010

Merged
llxia merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:disablefipsjclsecurity
Feb 23, 2024
Merged

llxia merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:disablefipsjclsecurity

Conversation

@JasonFengJ9

@JasonFengJ9 JasonFengJ9 commented Feb 23, 2024 •

Copy link
Copy Markdown
Member

FIPS disable JCL_TEST_Java-Security tests

related #16900

Signed-off-by: Jason Feng fengj@ca.ibm.com

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@llxia
llxia merged commit 49dff11 into eclipse-openj9:master Feb 23, 2024
@JasonFengJ9
JasonFengJ9 deleted the disablefipsjclsecurity branch February 24, 2024 11:31
@pshipton

Copy link
Copy Markdown
Member

@llxia this disabled the test completely in the IBM Java 8 builds. Do you have a suggestion to resolve that?

@pshipton

Copy link
Copy Markdown
Member

The other question is, how many other tests have been similarly disabled?

@llxia

llxia commented Mar 1, 2024 •

Copy link
Copy Markdown
Contributor

This should only be disabled when TEST_FLAG=FIPS140_2. See JCL_TEST_Java-Security_SE80 in regular JDK8 build in Jenkins

@llxia

llxia commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Do you mean vmfarm build?

@pshipton

pshipton commented Mar 1, 2024

Copy link
Copy Markdown
Member

Yes I mean the vmfarm build.

@llxia

llxia commented Mar 1, 2024 •

Copy link
Copy Markdown
Contributor
  • I think there are 2 ways:
  1. update the internal TKG version. This may cause other issues.
  2. Separate JCL_TEST_Java-Security test into 2 test targets. One for impl=ibm and one for impl=openj9. For impl=openj9, disable it based on testflag. For impl=ibm, no disable. This will allow the automation builds to run as expected.

I prefer the second way. For the first one, I am not sure what additional issues it may introduce.

  • how many other tests have been similarly disabled?

This will only affect tests that run for IBM java 8 and are disabled via testflag. I found the following 4 tests (including JCL_TEST_Java-Security):

<testCaseName>cmdLineTester_verbosetest</testCaseName>

<testCaseName>jit_hw</testCaseName>

<testCaseName>cmdLineTester_SCHelperCompatTests_win</testCaseName>

<testCaseName>JCL_TEST_Java-Security_SE80</testCaseName>

  • for the tests that run in JDK8 Jenkins, is there much value in running them in vmfarm again?

@pshipton

pshipton commented Mar 1, 2024

Copy link
Copy Markdown
Member

Could we try a build with a TKG update to see what issues there are? In the long term it will be easier if TKG supports the flags rather than having to deal with this for every existing and future test exclusion. IBM Java 8 will continue to 2030 and perhaps beyond.

IBM Java 8 isn't exactly the same as OpenJ9 8, there is different code, different defaults, the JIT may behave differently due to these things. It's hard to tell what testing matters and what doesn't.

@llxia

llxia commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

An internal issue (backlog/issues/1367) is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants