Skip to content

Fix romclass comparison and J9Class lookup given a romclass - #19833

Merged
pshipton merged 1 commit into
eclipse-openj9:masterfrom
hangshao0:FixSCC
Jul 10, 2024
Merged

pshipton merged 1 commit into
eclipse-openj9:masterfrom
hangshao0:FixSCC

Conversation

@hangshao0

Copy link
Copy Markdown
Contributor
  1. The romclass comparsion should include the ROM_CLASS_MODIFIERS.
  2. For a ROMClass from SCC, its rom memory segment always belongs to the bootstrap class loader. But the class might not be actually loaded by the bootstrap loader. Search all live class loaders to find its defining class loader and the corresponding J9Class.

Fixes #19781

@hangshao0
hangshao0 requested a review from pshipton July 9, 2024 18:18
@pshipton

pshipton commented Jul 9, 2024

Copy link
Copy Markdown
Member

What testing has already been run?

Comment thread runtime/vm/exceptiondescribe.c Resolved
@hangshao0

Copy link
Copy Markdown
Contributor Author

What testing has already been run?

I have run jsr292Test_0 and StackWalkerTest_0 with SCC and AOT enabled.

@pshipton

pshipton commented Jul 9, 2024

Copy link
Copy Markdown
Member

jenkins test sanity,extended,sanity.openjdk,sanity.system,extended.system amac jdk11

@pshipton

pshipton commented Jul 9, 2024

Copy link
Copy Markdown
Member

@hangshao0
hangshao0 force-pushed the FixSCC branch 2 times, most recently from cee711c to 6472d14 Compare July 10, 2024 14:45
@hangshao0

Copy link
Copy Markdown
Contributor Author

Internal JDK11 sanity.openjdk personal build on aarch64_mac passed with the current change.

This can be reviewed again.

Comment thread runtime/vm/exceptiondescribe.c Resolved
1. The romclass comparsion should include the ROM_CLASS_MODIFIERS.
2. For a ROMClass from SCC, its rom memory segment always belongs to the
bootstrap class loader. But the class might not be actually loaded by
the bootstrap loader. Search all live class loaders to find its defining
class loader and the corresponding J9Class.

Fixes eclipse-openj9#19781

Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
@pshipton

Copy link
Copy Markdown
Member

jenkins test sanity,extended,sanity.openjdk,sanity.system,extended.system amac jdk11

@pshipton
pshipton merged commit d400c62 into eclipse-openj9:master Jul 10, 2024
hangshao0 added a commit to hangshao0/openj9 that referenced this pull request Jul 11, 2024
related to eclipse-openj9#19833

Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants