Skip to content

Fix TimeUtilities thread number counting synchronization - #20638

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:timerun
Nov 21, 2024
Merged

tajila merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:timerun

Conversation

@JasonFengJ9

Copy link
Copy Markdown
Member

Fix TimeUtilities thread number counting synchronization

Use AtomicInteger to update the thread number atomically.

closes #20464

Signed-off-by: Jason Feng fengj@ca.ibm.com

Use AtomicInteger to update the thread number atomically.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9 JasonFengJ9 added comp:test criu Used to track CRIU snapshot related work labels Nov 19, 2024
@JasonFengJ9
JasonFengJ9 requested a review from tajila November 19, 2024 16:47
@tajila

tajila commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional alinux64 jdk21

@JasonFengJ9

Copy link
Copy Markdown
Member Author

https://openj9-jenkins.osuosl.org/job/Build_JDK21_aarch64_linux_Personal/444/consoleFull

15:00:35  ERROR: Build failed for target 'all' in configuration 'linux-aarch64-server-release' (exit code 2) 
15:00:35  
15:00:35  === Output from failing command(s) repeated here ===
15:00:35  * For target buildtools_tools_jigsaw_classes__the.BUILD_JIGSAW_TOOLS_batch:
15:00:35  [stderr] java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@6af42aba[Not completed, task = javacserver.server.CompilerThreadPool$$Lambda/0x0000000018251f10@99c81b05] rejected from java.util.concurrent.ThreadPoolExecutor@eeeffb29[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 9]
15:00:35  [stderr] 	at java.base/java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2081)
15:00:35  [stderr] 	at java.base/java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:841)
15:00:35  [stderr] 	at java.base/java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1376)
15:00:35  [stderr] 	at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:145)
15:00:35  [stderr] 	at javacserver.server.CompilerThreadPool.dispatchCompilation(CompilerThreadPool.java:49)
15:00:35  [stderr] 	at javacserver.server.Server.handleRequest(Server.java:211)
15:00:35  [stderr] 	at javacserver.server.Server.lambda$start$1(Server.java:173)
15:00:35  [stderr] 	at java.base/java.lang.Thread.run(Thread.java:1595)

This is a known issue that is not related to this PR change.

@tajila

tajila commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional alinux64 jdk21

@tajila
tajila merged commit 81bdf47 into eclipse-openj9:master Nov 21, 2024
@tajila

tajila commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Please backport to 0.49

@JasonFengJ9

Copy link
Copy Markdown
Member Author

@tajila Please review #20659

@JasonFengJ9
JasonFengJ9 deleted the timerun branch April 22, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:test criu Used to track CRIU snapshot related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRIU testTimeCompensation failure taskStarted: 9, taskExecuted: 8

2 participants