Skip to content

Valhalla bringup for Java 25 updates - #20911

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:valhalla25
Jan 13, 2025
Merged

tajila merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:valhalla25

Conversation

@JasonFengJ9

@JasonFengJ9 JasonFengJ9 commented Jan 10, 2025 •

Copy link
Copy Markdown
Member

Valhalla bringup for Java 25 updates

Updated -source to 25;
Updated VALUE_TYPE_CLASS_FILE_VERSION to 69;
Updated VALUE_TYPES_MAJOR_VERSION to 69.

This change is required for Valhalla extension Java 25 update

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 added comp:test project:valhalla Used to track Project Valhalla related work labels Jan 10, 2025

@theresa-m theresa-m left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VALUE_TYPES_MAJOR_VERSION will also need updating.

Updated -source to 25;
Updated VALUE_TYPE_CLASS_FILE_VERSION to 69;
Updated VALUE_TYPES_MAJOR_VERSION to 69.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9 JasonFengJ9 changed the title Valhalla test bringup for Java 25 Valhalla bringup for Java 25 updates Jan 10, 2025
@JasonFengJ9

Copy link
Copy Markdown
Member Author

VALUE_TYPES_MAJOR_VERSION will also need updating.

Fixed.

@JasonFengJ9
JasonFengJ9 requested a review from theresa-m January 10, 2025 21:05
@tajila

tajila commented Jan 11, 2025

Copy link
Copy Markdown
Contributor

jenkins test sanity.functional alinux64 jdk17

@tajila

tajila commented Jan 11, 2025

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended xlinuxval jdknext

@JasonFengJ9

Copy link
Copy Markdown
Member Author

Also: org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 5619fac9-730f-4f6c-981a-6a5c431966ea
java.lang.AssertionError: Build failed because cannot find NUM_LIST in parallelList.mk file.. Expression: assert false : "Build failed because cannot find NUM_LIST in parallelList.mk file."

It seems an infra error.

This PR passed a personal build along with ibmruntimes/openj9-openjdk-jdk.valuetypes#17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:test comp:vm project:valhalla Used to track Project Valhalla related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants