Skip to content

Protect entryName from being collected by the GC - #20940

Merged
gacholio merged 1 commit into
eclipse-openj9:masterfrom
babsingh:main13
Jan 17, 2025
Merged

gacholio merged 1 commit into
eclipse-openj9:masterfrom
babsingh:main13

Conversation

@babsingh

@babsingh babsingh commented Jan 15, 2025 •

Copy link
Copy Markdown
Contributor

j9gc_createJavaLangString can release VM access, which allows the GC
to move or collect objects. To prevent this, entryName is pushed to
a special frame before the call to j9gc_createJavaLangString. This
ensures that entryName is protected from being moved or collected by
the GC.

Related: #20870

j9gc_createJavaLangString can release VM access, which allows the GC
to move or collect objects. To prevent this, entryName is pushed to
a special frame before the call to j9gc_createJavaLangString. This
ensures that entryName is protected from being moved or collected by
the GC.

Related: eclipse-openj9#20870

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
babsingh marked this pull request as ready for review January 15, 2025 19:45
@babsingh
babsingh requested a review from gacholio January 15, 2025 19:46
@babsingh

Copy link
Copy Markdown
Contributor Author

@gacholio Requesting your review.

@gacholio

Copy link
Copy Markdown
Contributor

jenkins test sanity zlinux jdknext

@babsingh

Copy link
Copy Markdown
Contributor Author

jdknext points to jdk25, which might be more unstable than jdk24. also, starting jdk24 builds.

jenkins test sanity amac jdk24

@babsingh

Copy link
Copy Markdown
Contributor Author

The failures seen in the PR builds are unrelated to these changes.

@gacholio
gacholio merged commit a843c7e into eclipse-openj9:master Jan 17, 2025
a7ehuo pushed a commit to a7ehuo/openj9 that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants