Skip to content

Disable cmdLineTester_libpathTestRtfChild for headless riscv64_linux built at Adoptium - #20962

Merged
llxia merged 1 commit into
eclipse-openj9:masterfrom
andrew-m-leonard:disable_libpathTestRtfChild
Jan 17, 2025
Merged

llxia merged 1 commit into
eclipse-openj9:masterfrom
andrew-m-leonard:disable_libpathTestRtfChild

Conversation

@andrew-m-leonard

Copy link
Copy Markdown
Contributor

Adoptium builds riscv64_linux "headless", test cmdLineTester_libpathTestRtfChild needs excluding for headless builds
Ref: adoptium/aqa-tests#5879

…built at Adoptium

Signed-off-by: Andrew Leonard <anleonar@redhat.com>

@llxia llxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
llxia merged commit e54606e into eclipse-openj9:master Jan 17, 2025
@sophia-guo

Copy link
Copy Markdown
Contributor

I think a better way to do the exclusion is adding exclude entry with specified platform to https://github.com/eclipse-openj9/openj9/blob/cccf21d2cb7f7ec80498ef97b8673c6a1a6c8aa2/test/functional/cmdLineTests/libpathTest/exclude_rtfchild.xml , format is similar to Windows does not support * symbol.

Test DefaultStyledDocument styledDoc = new DefaultStyledDocument(); requires libawt_xawt.so , which should be disabled for headless platforms by default. No need to track with an open issue in Adoptium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants