Repository navigation
Reduce the amount of fanin info collected by IProfiler - #20975
Merged
Merged
Conversation
mpirvu
force-pushed
the
faninfo-memreduction
branch
from
January 20, 2025 17:06
ef7953e to
a876c48
Compare
Contributor
Author
|
@dsouzai Please review/merge this PR. Thanks |
dsouzai
requested changes
Jan 20, 2025
dsouzai
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM; requested minor cleanup of MIN_FAN_IN_SIZE.
The only consumer of the fanin info is the inliner. However, the inliner will ignore the fanin data for any method (callee) that is less than 50 bytecodes. Thus, it makes sense to avoid storing fanin info for such small methods. With this change the number of entries stored by the fanin mechanism is reduced by about 72%. This is expected to reduce footprint somewhat and to reduce the overhead of the methodinfo hashtable which stores fanin info. The threshold that decides what is considered a small method from the fanin mechanism point of view can be changed with `-Xjit:iprofilerFaninMethodMinSize=` option (default is 50 bytecodes) Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
mpirvu
force-pushed
the
faninfo-memreduction
branch
from
January 20, 2025 18:36
a876c48 to
5b93a77
Compare
dsouzai
approved these changes
Jan 20, 2025
Contributor
|
jenkins test sanity.functional xlinux,plinux,zlinux jdk8,jdk21 |
Contributor
Author
|
All tests have passed. This PR is ready to be merged. |
mpirvu
added a commit
to mpirvu/openj9
that referenced
this pull request
Jan 24, 2025
PR eclipse-openj9#20975 is known to cause some throughput regressions. These regressions are caused by limiting the IProfiler to collect fanin info only for methods larger than 50 bytecodes. It turns out that the code in `isLargeCompiledMethod()` does not refer to the size of the callee in the variable called `bytecodeSize`. `bytecodeSize` is actually some computed value which can be much bigger than the size of the callee. This commit eliminates the code that restricts the fanin info to the methods larger than 50 bytecodes, but leaves all the other changes of PR eclipse-openj9#20975 intact. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
vijaysun-omr
added a commit
that referenced
this pull request
Jan 24, 2025
Effectively revert PR #20975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only consumer of the fanin info is the inliner. However, the inliner will ignore the fanin data for any method (callee) that is less than 50 bytecodes. Thus, it makes sense to avoid storing fanin info for such small methods.
With this change the number of entries stored by the fanin mechanism is reduced by about 72%. This is expected to reduce footprint somewhat and to reduce the overhead of the methodinfo hashtable which stores fanin info.
The threshold that decides what is consiredered a small method from the fanin mechanism point of view can be changed with
-Xjit:iprofilerFaninMethodMinSize=option (default is 50 bytecodes)