Repository navigation
IL Generation for defaultvalue bytecode instruction - #9030
Conversation
|
Andrew @andrewcraik, may I ask you to review this change? |
|
@DanHeidinga could we have your review for the change in the runtime/jit_vm/ctsupport.cpp ? |
|
Jenkins test sanity all jdk14 |
DanHeidinga
left a comment
There was a problem hiding this comment.
Treating L & Q identically is probably the right initial choice. Is it worth differentiating them now though? We'll likely want to treat them differently as we look at optimized calling sequences, etc
Dan @DanHeidinga, you're right about wanting to treat the two differently, of course. I'd be happy to define a |
|
Can you add a |
b9a2347 to
79d5737
Compare
3035978 to
2af5c52
Compare
The experimental value types support uses the letter Q before the class name for a value type class. This change handles the following cases: 1) In building a TR:TypeLayout in J9ClassEnv.cpp, treat a field that has Q before a class name as being of type TR::Address. 2) The code in TR_J9VM::getClassFromSignature strips off any leading 'L' and trailing semicolon from the signature string for a class that it is looking up. For value types, it also needs to strip off any leading 'Q'. 3) In jitParseSignature in ctsupport.cpp, allow for the letter Q before a class name in parsing signatures. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
For a defaultvalue bytecode, if the class is resolved, generate a newvalue instruction with default values for the fields as operands. Recursively generate a newvalue for any fields that are themselves value types. The JIT compiler is not yet able to handle the case of an unresolved class used in a defaultvalue bytecode instruction. Simply fail the compilation during ILGen if an unresolved class is encountered in that situation. The failure is reported as an UnsupportedValueTypeOperation exception. The intention is that these can be replaced with OSR points in the future. In order to track the frequency with which we are failing compilations due to encountering unresolved classes during IL generation for the defaultvalue bytecode, use static debug counters that begin with the string "ilgen.abort/unresolved/defaultvalue". Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
2af5c52 to
c34da9e
Compare
|
@andrewcraik I'll leave builds and merging to you |
|
Jenkins test sanity all jdk14 |
|
390 failed with infra issues rest of the builds are clean and there is nothing 390 specific so this can merge. |
This change adds prototype IL generation support for the value type
defaultvaluebytecode in the case where the class specified is resolved. If the class is unresolved, the JIT compilation is aborted with anUnsupportedValueTypeOperationexception.