Skip to content

[125499] Add missing fields in monitoring logstash mb template mapping - #127053

Merged
mashhurs merged 6 commits into
elastic:mainfrom
ijardillier:add-missing-fields-template-monitoring-logstash
Oct 8, 2025
Merged

mashhurs merged 6 commits into
elastic:mainfrom
ijardillier:add-missing-fields-template-monitoring-logstash

Conversation

@ijardillier

Copy link
Copy Markdown
Contributor

This commit adds some missing fields in monitoring template (logstash).

Closes #125499

@ijardillier
ijardillier requested a review from a team as a code owner April 18, 2025 12:26
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v9.1.0 labels Apr 18, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Apr 21, 2025
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 21, 2025
@consulthys consulthys added >enhancement needs:triage Requires assignment of a team area label and removed Team:Data Management (obsolete) DO NOT USE. This team no longer exists. labels Apr 21, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management (obsolete) DO NOT USE. This team no longer exists. and removed needs:triage Requires assignment of a team area label labels Apr 21, 2025
@robbavey
robbavey requested a review from mashhurs September 30, 2025 17:55
@pickypg

pickypg commented Oct 2, 2025

Copy link
Copy Markdown
Member

Hi @ijardillier, can you please sign the CLA? Once done, I can add the changelog and we can look at merging this.

@ijardillier

Copy link
Copy Markdown
Contributor Author

Hi @pickypg, I've just signed it.

@pickypg

pickypg commented Oct 2, 2025

Copy link
Copy Markdown
Member

I just noticed that this branch is in your forked repository. Can you:

  1. Pull down upstream changes to this PR (two merges against the main branch that are probably not in your local branch)
  2. Add a file named docs/changelog/127053.yaml
  3. Push new file
pr: 127053
summary: Add missing fields to the Logstash Stack Monitoring Template
area: Stack Monitoring
type: enhancement
issues:
 - 125499

@dakrone

dakrone commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Don't forget to increment MonitoringTemplateRegistry.STACK_MONITORING_REGISTRY_VERSION so that this new version will be installed on upgrade.

@mashhurs

mashhurs commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

@ijardillier I have pulled your change, validated and suggested more fields with https://github.com/ijardillier/elasticsearch/pull/1 PR.
The PR also adds changelog and bumps the template version. If you merge my suggestion, I will do overall review, so far going to a right direction.

FYI: @pickypg, it seems we don't have Stack Monitoring area but we have just Monitoring. Let me know if it needs to be changed.

CC: @dakrone

Thank you all!

@pickypg

pickypg commented Oct 2, 2025

Copy link
Copy Markdown
Member

seems we don't have Stack Monitoring area but we have just Monitoring. Let me know if it needs to be changed.

Monitoring works.

…illier

Add changelog, more missed fields and validate.
@mashhurs mashhurs self-assigned this Oct 7, 2025
@mashhurs

mashhurs commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

@elasticmachine test this

@mashhurs
mashhurs enabled auto-merge (squash) October 7, 2025 22:18

@pickypg pickypg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashhurs
mashhurs merged commit fffc499 into elastic:main Oct 8, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Monitoring DEPRECATED, DO NOT USE >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Stack Monitoring v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing mappings in monitoring-logstash-mb template

6 participants