Repository navigation
Conversation
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @parkertimmins, I've created a changelog YAML for you. |
martijnvg
approved these changes
Nov 26, 2025
| int blockDocOffset = 0; | ||
| int blockByteOffset = 0; | ||
| long[] offsets = new long[count + 1]; | ||
| List<BytesRef> decompressedBlocks = new ArrayList<>(); |
Member
There was a problem hiding this comment.
Maybe add a TODO, to account memory usage of decompressedBlocks? This could grow and have a significant jvm heap memory usage.
Eventually this will be accounted, but that happens when we hand over byte[] to the builder.
Member
|
I suspect most of the bwc failures are because of: |
…ing-compressed-binary-dv-dense
3 of 6 tasks
martijnvg
enabled auto-merge (squash)
November 27, 2025 09:18
This was referenced Dec 8, 2025
martijnvg
added a commit
that referenced
this pull request
Dec 15, 2025
This change iterates on top of #138631 and attempts to simplify the bulk read logic and improves testing. It is try to simplify the bulk reading by find to first matching block id and the last matching block id for the documents values need to be loaded. Then it just de-compress and streams the values and offset into buffers that then get appended to the block builder. Relates to #138983
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
Dec 17, 2025
This change iterates on top of elastic#138631 and attempts to simplify the bulk read logic and improves testing. It is try to simplify the bulk reading by find to first matching block id and the last matching block id for the documents values need to be loaded. Then it just de-compress and streams the values and offset into buffers that then get appended to the block builder. Relates to elastic#138983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By decompressing all matching blocks into one byte array and appending that directly into the block builder.