Repository navigation
ESQL 137269 some csv tests for lookup join behavior with multivalues - #144520
Merged
Merged
Conversation
Lookup join where several records on the right contain multivalues should produce a single null. 2,German,[Germany,Austria] 2,German,[Germany,Belgium]
cimequinox
force-pushed
the
esql_csv_changes_for_137269
branch
from
March 18, 2026 19:48
e3cc8e5 to
5208cc5
Compare
cimequinox
marked this pull request as ready for review
March 19, 2026 04:23
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @cimequinox, I've created a changelog YAML for you. |
ncordon
approved these changes
Mar 19, 2026
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Mar 20, 2026
…lastic#144520) This is a small change to ESQL CSV tests which * adds an additional near-duplicate row to languages_non_unique_key.csv to help test lookup join in the case where several records on the right side of the join contain multivalues. 2,German,[Germany,Austria] 2,German,[Germany,Belgium] ◀─ added row * adds a few csv tests to lookup-join.csv-spec which use this to test desired behavior. * updates inlinestats.csv-spec and views.csv-spec to compensate for the change * updates docs/changelog/144520.yaml
14 tasks done
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
…lastic#144520) This is a small change to ESQL CSV tests which * adds an additional near-duplicate row to languages_non_unique_key.csv to help test lookup join in the case where several records on the right side of the join contain multivalues. 2,German,[Germany,Austria] 2,German,[Germany,Belgium] ◀─ added row * adds a few csv tests to lookup-join.csv-spec which use this to test desired behavior. * updates inlinestats.csv-spec and views.csv-spec to compensate for the change * updates docs/changelog/144520.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change to ESQL CSV tests which
to help test lookup join in the case where several records on the right side of the join contain multivalues.
Adding this in advance of separate PR for #137269 optimization