Skip to content

ESQL 137269 some csv tests for lookup join behavior with multivalues - #144520

Merged
cimequinox merged 5 commits into
elastic:mainfrom
cimequinox:esql_csv_changes_for_137269
Mar 19, 2026
Merged

cimequinox merged 5 commits into
elastic:mainfrom
cimequinox:esql_csv_changes_for_137269

Conversation

@cimequinox

@cimequinox cimequinox commented Mar 18, 2026 •

Copy link
Copy Markdown
Contributor

This is a small change to ESQL CSV tests which

  1. adds an additional near-duplicate row to languages_non_unique_key.csv
    to help test lookup join in the case where several records on the right side of the join contain multivalues.

2,German,[Germany,Austria]
2,German,[Germany,Belgium] ◀─ added row

  1. adds a few csv tests to lookup-join.csv-spec which use this to test desired behavior.
  2. updates inlinestats.csv-spec and views.csv-spec to compensate for the change

Adding this in advance of separate PR for #137269 optimization

Lookup join where several records on the right contain multivalues
should produce a single null.

2,German,[Germany,Austria]
2,German,[Germany,Belgium]
@cimequinox
cimequinox force-pushed the esql_csv_changes_for_137269 branch from e3cc8e5 to 5208cc5 Compare March 18, 2026 19:48
@cimequinox
cimequinox marked this pull request as ready for review March 19, 2026 04:23
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Mar 19, 2026
@cimequinox cimequinox added >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Mar 19, 2026
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Mar 19, 2026
@elasticsearchmachine

Copy link
Copy Markdown
Collaborator

Hi @cimequinox, I've created a changelog YAML for you.

@cimequinox
cimequinox merged commit e18f449 into elastic:main Mar 19, 2026
36 checks passed
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Mar 20, 2026
…lastic#144520)

This is a small change to ESQL CSV tests which

* adds an additional near-duplicate row to languages_non_unique_key.csv to help test lookup join in the case where several records on the right side of the join contain multivalues.

2,German,[Germany,Austria]
2,German,[Germany,Belgium] ◀─ added row

* adds a few csv tests to lookup-join.csv-spec which use this to test desired behavior.
* updates inlinestats.csv-spec and views.csv-spec to compensate for the change
* updates docs/changelog/144520.yaml
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
…lastic#144520)

This is a small change to ESQL CSV tests which

* adds an additional near-duplicate row to languages_non_unique_key.csv to help test lookup join in the case where several records on the right side of the join contain multivalues.

2,German,[Germany,Austria]
2,German,[Germany,Belgium] ◀─ added row

* adds a few csv tests to lookup-join.csv-spec which use this to test desired behavior.
* updates inlinestats.csv-spec and views.csv-spec to compensate for the change
* updates docs/changelog/144520.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants