Repository navigation
Validate base64 embedding inputs use data URI format - #145038
Merged
DonalEvans merged 15 commits intoApr 3, 2026
Merged
DonalEvans merged 15 commits into
DonalEvans merged 15 commits into
Conversation
The EMBEDDING task type requires that image inputs using the BASE64
format are data URIs. This commit adds validation that inputs using the
BASE64 format conform to the data URI format; i.e. that they begin
with "data:{some text}/{some other text};base64,"
This validation does not guarantee that the specified MIME type is
valid, that the MIME type matches the base64 data, or that the base46
data in the input is valid.
Collaborator
|
Hi @DonalEvans, I've created a changelog YAML for you. |
DonalEvans
marked this pull request as ready for review
March 26, 2026 22:25
Collaborator
|
Pinging @elastic/search-inference-team (Team:Search - Inference) |
DonalEvans
marked this pull request as draft
March 26, 2026 22:27
DonalEvans
requested review from
Jan-Kazlouski-elastic,
dimitris-athanasiou and
jonathan-buttner
April 1, 2026 19:51
DonalEvans
marked this pull request as ready for review
April 1, 2026 19:51
Jan-Kazlouski-elastic
left a comment
Contributor
There was a problem hiding this comment.
Overall looking good. Left a few comments, one for regex, other for inlining in tests.
Jan-Kazlouski-elastic
approved these changes
Apr 2, 2026
dimitris-athanasiou
approved these changes
Apr 3, 2026
mromaios
pushed a commit
to mromaios/elasticsearch
that referenced
this pull request
Apr 9, 2026
The EMBEDDING task type requires that image inputs using the BASE64
format are data URIs. This commit adds validation that inputs using the
BASE64 format conform to the data URI format; i.e. that they begin
with "data:{some text}/{some other text};base64,"
This validation does not guarantee that the specified MIME type is
valid, that the MIME type matches the base64 data, or that the base46
data in the input is valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EMBEDDING task type requires that image inputs using the BASE64 format are data URIs. This commit adds validation that inputs using the BASE64 format conform to the data URI format; i.e. that they begin with "data:{some text}/{some other text};base64,"
This validation does not guarantee that the specified MIME type is valid, that the MIME type matches the base64 data, or that the base46 data in the input is valid.
Closes #144900