Repository navigation
[8.19] Failure-store failures yield O(N²) message sizes [#157859] (#162017) - #162487
Merged
Merged
Conversation
…astic#162017) * Seperate out failure store exceptions from main bulk failure exception * Address PR comment and add support for stack trace printing of additional exceptions * Update docs/changelog/162017.yaml * [CI] Update transport version definitions * Update docs/changelog/162017.yaml Co-authored-by: Mary Gouseti <mgouseti@gmail.com> * Small PR feedback suggestion fixes * Switch to managing suppressed exceptions during serialization * Add assertion that document can't get 2 failure store errors --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> Co-authored-by: Mary Gouseti <mgouseti@gmail.com> (cherry picked from commit d4e4eab) # Conflicts: # server/src/main/java/org/elasticsearch/ElasticsearchException.java # server/src/main/java/org/elasticsearch/action/bulk/BulkItemResponse.java # server/src/main/java/org/elasticsearch/action/bulk/BulkOperation.java # server/src/main/java/org/elasticsearch/action/search/SearchPhaseExecutionException.java # server/src/main/resources/transport/upper_bounds/9.4.csv # server/src/main/resources/transport/upper_bounds/9.5.csv # server/src/main/resources/transport/upper_bounds/9.6.csv # server/src/test/java/org/elasticsearch/ElasticsearchExceptionTests.java # server/src/test/java/org/elasticsearch/action/bulk/BulkItemResponseFailureWireSerializingTests.java # server/src/test/java/org/elasticsearch/action/bulk/BulkItemResponseTests.java # server/src/test/java/org/elasticsearch/action/bulk/BulkOperationTests.java
romseygeek
approved these changes
Oct 19, 2026
|
|
||
| /** | ||
| * Records that handling an already failed document with the failure store also failed. The cause of the original failure may be | ||
| * shared by every item of a failed shard bulk, so adding to it once per item grows the response quadratically (see #157859). Older |
Contributor
There was a problem hiding this comment.
Maybe reword this comment to make it clearer that we are only writing it once, so that we are avoiding the quadratic repetition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation