Repository navigation
fix: settle helpers that were still working when a run paused - #1920
Merged
Merged
Conversation
The executor stopped reading runtime events on pause, leaving helper terminal events in an unread queue and their persisted state running. Settle unfinished helpers before pauses and finalization and during exit cleanup. Guard live and reloaded projections with run state and pause history while keeping new helpers active after resume. Fixes #1902
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new blocking issues were found. SummaryStops unfinished helpers before a run pauses or ends, and settles stale helper cards in shared projections, web, mobile, and snapshot reloads.
|
Contributor
Playwright screenshotsNo new feature frames; gallery is suite-vs-main drift. Open screenshot gallery · Dashboard · CI run Updated for commit |
fgbhhnnn
added a commit
to fgbhhnnn/rakazo
that referenced
this pull request
Oct 23, 2026
Keeps fork dispatcher design (hidden workers, no Stop, busy indicator, owner-managed deployment settings); takes upstream bug fixes from elie222#1685/elie222#1891/elie222#1920/elie222#1899 and the interactive/background worker lanes with hidden workers forced onto the background lane.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Helpers (
run_subagent) that were still working when a run paused for an approval, question or takeover kept showing as running forever, including after the run resumed or finished and after a reload. The helpers did stop, but their terminal events were queued after the executor had stopped reading the runtime stream, so the last stored event for each one stayedrunning. Every pause left another set of spinners behind.What changed
failed/stoppedevent for any that are unfinished before a pause and before finishing, with exit cleanup covering cancellation and runtime failures.The only visible change is that stopped helpers use their existing stopped state. No copy, layout, migration or auth changes.
Tests
Regression tests were written first and failed before the fix: helper persistence on pause, finish, failure and cancel (executor); projection on input pause, takeover pause, completed, failed and cancelled without reviving old helpers on resume (core, web, mobile); and snapshot reload settlement in bot and group chats, including a resumed run with fresh helpers. All touched-package unit suites, typechecks and Biome pass.
Fixes #1902