Skip to content

fix(mobile): keep the archived list below its header - #1927

Merged
elie222 merged 2 commits into
elie222:mainfrom
ald3b:fix/archived-list-inset
Oct 23, 2026
Merged

elie222 merged 2 commits into
elie222:mainfrom
ald3b:fix/archived-list-inset

Conversation

@ald3b

@ald3b ald3b commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Why

On iOS 26 the Archived screen's first row could end up under the floating header: the close button covered the row's icon and the "Archived" title sat across its middle. It happened when the screen was opened after the text size changed while the app was running. A fresh launch looked right, so it came and went.

What changed

  • The archived list took its top inset from the native host's safe area, which isn't always current after a text size change.
  • On iOS 26, where the header floats over the content, the list now ignores the host's safe area and pads its top by the header's height, which comes from navigation and is always current. The bottom keeps its existing spacer for the home indicator.
  • Older iOS, where the header doesn't float, is unchanged.

No copy changes.

How it was tested

On an iOS 27 Simulator with a Debug build against a local server. The test account had one archived group, "Test". Light and dark mode were both checked.

  • Before: with the app open, changing the text size and then opening Archived put the close button and title on top of the "Test" row in most tries, in light and dark.
  • After: the row starts below the header in the same place as on a fresh launch, both after a text size change and normally, in light and dark.

Unit test (new, fails without the change): with a floating header, the host ignores the container safe area and the list's top padding equals the header height. Without one, nothing changes.

Suites. The mobile tests, typecheck and lint pass.

Mobile. CI can't capture the native list; the results above come from a simulator.

🤖 Generated with Claude Code

The archived chats list took its top inset from the native host's safe
area. After a text size change that inset could be missing, and the first
row slid under the close button and the "Archived" title. The list now
ignores the host's safe area and pads its top by the floating header's
height, which comes from navigation and is always current.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
rakazo-www Skipped Skipped Oct 23, 2026 7:05am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable defects were found.

Summary

Keeps the archived list below the floating header on newer iOS versions.

  • Archived rows now start below the floating header.

No actionable new issues were found. Native appearance was not independently verified.

Reviews (2) · Last reviewed commit: "fix(mobile): let archived rows scroll un..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Playwright screenshots

No new feature frames; gallery is suite-vs-main drift.

Open screenshot gallery · Dashboard · CI run

Updated for commit 2316b0a.

@elie222
elie222 merged commit 010785d into elie222:main Oct 23, 2026
26 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 2316b0a8 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants