Repository navigation
fix(mobile): keep the archived list below its header - #1927
Merged
Merged
Conversation
The archived chats list took its top inset from the native host's safe area. After a text size change that inset could be missing, and the first row slid under the close button and the "Archived" title. The list now ignores the host's safe area and pads its top by the floating header's height, which comes from navigation and is always current. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
[Low impact] The PR appears safe to merge; no actionable defects were found. SummaryKeeps the archived list below the floating header on newer iOS versions.
No actionable new issues were found. Native appearance was not independently verified. Reviews (2) · Last reviewed commit: "fix(mobile): let archived rows scroll un..." · Reviewed by Greptile |
Contributor
Playwright screenshotsNo new feature frames; gallery is suite-vs-main drift. Open screenshot gallery · Dashboard · CI run Updated for commit |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On iOS 26 the Archived screen's first row could end up under the floating header: the close button covered the row's icon and the "Archived" title sat across its middle. It happened when the screen was opened after the text size changed while the app was running. A fresh launch looked right, so it came and went.
What changed
No copy changes.
How it was tested
On an iOS 27 Simulator with a Debug build against a local server. The test account had one archived group, "Test". Light and dark mode were both checked.
Unit test (new, fails without the change): with a floating header, the host ignores the container safe area and the list's top padding equals the header height. Without one, nothing changes.
Suites. The mobile tests, typecheck and lint pass.
Mobile. CI can't capture the native list; the results above come from a simulator.
🤖 Generated with Claude Code