Repository navigation
Add password visibility toggle to mobile signup and sign-in - #1941
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
 [Low impact] The PR appears safe to merge; the previous test-coverage finding is fully addressed. SummaryAdds a native password visibility toggle to mobile sign-in and signup.
Reviews (2) · Last reviewed commit: "Test password visibility resets across a..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile signup and sign-in now let people check their password with a native eye toggle, matching the existing web and desktop behavior.
Passwords remain hidden by default and are hidden again when switching forms, authentication methods, or servers.
The only new copy is the localized accessibility labels “Show password” and “Hide password”; these name the icon action for screen-reader users and must be available whenever the control is focused.
Validation: all 28 targeted authentication and shared-input tests passed, along with mobile TypeScript and formatting checks.
This is native-only mobile UI that web CI cannot capture, so there is no applicable web E2E screenshot; native device appearance has not been visually verified.