Repository navigation
Cancel desktop computer response reads promptly - #1958
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryDesktop computer requests now stop pending reads and buffered events when the caller cancels or the deadline expires.
No actionable issues were found. The full test suites were not run during this review.
|
Contributor
Playwright screenshotsNo new feature frames; gallery is suite-vs-main drift. Open screenshot gallery · Dashboard · CI run Updated for commit |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cancelling a desktop computer command can leave the client waiting on its response stream. Stop pending reads and buffered events as soon as the request is cancelled, so cancellation reliably reaches the host process.
What changed
Validation
Native computer transport and command suites pass locally, including a deterministic stream that ignores fetch cancellation and stalls cleanup. The real-process abort test also verifies that the child exits. Adapter type checking passes. Windows coverage runs in CI.